Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: used fixturesDir from fixtures modules #16813

Closed
wants to merge 1 commit into from

Conversation

kkogovsek
Copy link

I required common/fixtures module and swapped the location of fixturesDir
from common to fixtures module.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2017
@gireeshpunathil
Copy link
Member

@kkogovsek - looks like you pushed changed without:

#git config --global user.name
#git config --global user.email

on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again?

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@vsemozhetbyt
Copy link
Contributor

@kkogovsek kkogovsek force-pushed the master branch 2 times, most recently from 774834b to a340fd4 Compare November 7, 2017 09:02
@gireeshpunathil
Copy link
Member

@Trott
Copy link
Member

Trott commented Nov 7, 2017

Linter stalled in CI which was odd but undoubtedly unrelated to this change.

Re-running linter: https://ci.nodejs.org/job/node-test-linter/13348/

In test-fs-realpath-on-substed-drive:

Require common/fixtures module and swapped the location of fixturesDir
from common to fixtures module.
@Trott
Copy link
Member

Trott commented Nov 8, 2017

There was a lint error, so I fixed it up (added a semi-colon). Hope that's OK!

Need to re-run CI, but I'm having issues with CI right now....

@Trott
Copy link
Member

Trott commented Nov 8, 2017

@gireeshpunathil
Copy link
Member

old CI is 404 now, new CI: https://ci.nodejs.org/job/node-test-pull-request/11388/

gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

Landed in 1601a3c , thanks for the contribution!

evanlucas pushed a commit that referenced this pull request Nov 13, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants