build: include src\tracing when linting on win #16720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does.
nodejs-github-bot
added
build
jasnell
approved these changes
Nov 3, 2017
|
bonsoir
2017-11-03 17:59 GMT+01:00 James M Snell <notifications@github.com>:
… ***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16720 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVYMKeEdwF72TARZxweV8d57nAbL84WIks5sy0aJgaJpZM4QROyd>
.
|
test/arm-fanned failure looks unrelatedReinitialized existing Git repository in /home/iojs/build/workspace/node-test-binary-arm/.git/
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/master:refs/remotes/reference/master +refs/heads/v4.x-staging:refs/remotes/reference/v4.x-staging +refs/heads/v6.x-staging:refs/remotes/reference/v6.x-staging +refs/heads/v7.x-staging:refs/remotes/reference/v7.x-staging +refs/heads/v8.x-staging:refs/remotes/reference/v8.x-staging
fatal: Couldn't find remote ref refs/heads/v7.x-staging
fatal: The remote end hung up unexpectedly
real 0m13.370s
user 0m0.110s
sys 0m0.100s
+ echo 'Problem fetching the shared reference repo.'
Problem fetching the shared reference repo.
+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6:refs/remotes/jenkins_tmp
From file:///home/iojs/.ccache/node.shared.reference
+ 86687d80ff...64bed96866 jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6 -> jenkins_tmp (forced update)
real 0m42.005s
user 0m17.810s
sys 0m5.630s
+ rm -f ****
+ git checkout -f refs/remotes/jenkins_tmp
Warning: you are leaving 2 commits behind, not connected to
any of your branches:
86687d80ff added binaries
9213800a13 deps: ICU 60 bump
If you want to keep them by creating a new branch, this may be a good time
to do so with:
git branch <new-branch-name> 86687d80ff
HEAD is now at 64bed96866... added binaries
real 0m37.907s
user 0m4.160s
sys 0m23.050s
+ git reset --hard
HEAD is now at 64bed96866 added binaries
real 0m12.236s
user 0m3.520s
sys 0m3.090s
+ git clean -fdx
warning: failed to remove out/Release/.nfs00000000002bfbf000000113: Device or resource busy
Removing config.gypi
Removing icu_config.gypi
Removing node
Removing out/Release/node
Removing out/Release/openssl-cli
Removing test.tap
Removing test/.tmp.0/
Removing test/abort/testcfg.pyc
Removing test/addons-napi/testcfg.pyc
Removing test/addons/testcfg.pyc
Removing test/async-hooks/testcfg.pyc
Removing test/doctool/testcfg.pyc
Removing test/es-module/testcfg.pyc
Removing test/gc/testcfg.pyc
Removing test/internet/testcfg.pyc
Removing test/known_issues/testcfg.pyc
Removing test/message/testcfg.pyc
Removing test/parallel/testcfg.pyc
Removing test/pseudo-tty/testcfg.pyc
Removing test/pummel/testcfg.pyc
Removing test/sequential/testcfg.pyc
Removing test/testpy/__init__.pyc
Removing test/tick-processor/testcfg.pyc
Removing test/timers/testcfg.pyc
Removing tools/test.pyc
Removing tools/utils.pyc
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE |
|
cc @nodejs/platform-windows |
|
The problematic Raspberry Pi host has been disabled. Here's a re-run of Raspberry Pi CI: https://ci.nodejs.org/job/node-test-binary-arm/11625/ |
|
Landed in f002c3d |
danbev
added a commit
that referenced
this pull request
Nov 9, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Should this be backported to |
danbev
added a commit
to danbev/node
that referenced
this pull request
Nov 21, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. Refs: nodejs#16720 PR-URL: nodejs#16720 Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 26, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. Refs: #16720 Backport-PR-URL: #17172 PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. Refs: #16720 Backport-PR-URL: #17172 PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, windows