test: make debugging of inspector-port-zero easier #16685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Nov 2, 2017
| proc.on('exit', mustCall((exitCode, signal) => assert.strictEqual( | ||
| 0, | ||
| exitCode, | ||
| `exitCode was ${exitCode} not 0, signal was ${signal}`))); |
There was a problem hiding this comment.
"not 0" is tautological here.
As well, the order of arguments is actual, expected[, message]. You flipped them around here.
There was a problem hiding this comment.
"not 0" is tautological here.
True, just trying to save someone the trouble of having to look at the source. But thinking again, I think shorter is better.
As well, the order of arguments is actual, expected[, message]. You flipped them around here.
Huh, I always thought it was expected, actual, guess I have to relearn that.
Both fixed.
gibfahn
force-pushed
the
inspector-test
branch
from
65524b9
to
60a09fb
Compare
cjihrig
approved these changes
Nov 2, 2017
joyeecheung
approved these changes
Nov 2, 2017
eugeneo
approved these changes
Nov 2, 2017
jasnell
approved these changes
Nov 2, 2017
gireeshpunathil
approved these changes
Nov 3, 2017
lpinca
approved these changes
Nov 5, 2017
gibfahn
force-pushed
the
inspector-test
branch
from
60a09fb
to
4f9fed6
Compare
gibfahn
force-pushed
the
inspector-test
branch
from
4f9fed6
to
3feb60b
Compare
If the process was killed, then the exit code will be null, in which case knowing the signal is really helpful. PR-URL: nodejs#16685 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn
force-pushed
the
inspector-test
branch
from
3feb60b
to
5c7b1ec
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
If the process was killed, then the exit code will be null, in which case knowing the signal is really helpful. PR-URL: #16685 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
gibfahn
added a commit
that referenced
this pull request
Dec 19, 2017
If the process was killed, then the exit code will be null, in which case knowing the signal is really helpful. PR-URL: #16685 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Closed
gibfahn
added a commit
that referenced
this pull request
Dec 20, 2017
If the process was killed, then the exit code will be null, in which case knowing the signal is really helpful. PR-URL: #16685 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the process was killed, then the exit code will be null, in which
case knowing the signal is really helpful.
Adding this because it failed for me with
exitCodenull, which isn't very helpful.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test