src: pass context to Get() operations for cares_wrap #16641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
cjihrig
approved these changes
Oct 31, 2017
addaleax
approved these changes
Oct 31, 2017
src/cares_wrap.cc
Outdated
| int fam = elm->Get(env->context(), 0).ToLocalChecked()->Int32Value(); | ||
| node::Utf8Value ip(env->isolate(), | ||
| elm->Get(env->context(), 1).ToLocalChecked()); | ||
| int port = elm->Get(env->context(), 2).ToLocalChecked()->Int32Value(); |
There was a problem hiding this comment.
If you want, I think it would make sense to do the same for Int32Value as well
There was a problem hiding this comment.
Good catch. Thanks!
Using Get() without the context argument will soon be deprecated. This also passed context to Int32Value() operations as well.
|
Updated. New CI: https://ci.nodejs.org/job/node-test-pull-request/11116/ |
apapirovski
approved these changes
Nov 1, 2017
tniessen
approved these changes
Nov 1, 2017
jasnell
approved these changes
Nov 2, 2017
jasnell
pushed a commit
that referenced
this pull request
Nov 2, 2017
Using Get() without the context argument will soon be deprecated. This also passed context to Int32Value() operations as well. PR-URL: #16641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 635d064 |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
Using Get() without the context argument will soon be deprecated. This also passed context to Int32Value() operations as well. PR-URL: nodejs#16641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
@evanlucas this doesn't land cleanly on v6.x does it make sense to backport? |
gibfahn
pushed a commit
that referenced
this pull request
Nov 14, 2017
Using Get() without the context argument will soon be deprecated. This also passed context to Int32Value() operations as well. PR-URL: #16641 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Get() without the context argument will soon be deprecated.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src