doc: fix Changelog link order #16632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
cjihrig
approved these changes
Oct 31, 2017
mscdex
reviewed
Oct 31, 2017
CHANGELOG.md
Outdated
| * [Node.js 5](doc/changelogs/CHANGELOG_V5.md), | ||
| * [Node.js 4](doc/changelogs/CHANGELOG_V4.md) | ||
| [0.12](doc/changelogs/CHANGELOG_V012.md), | ||
| [0.10](doc/changelogs/CHANGELOG_V010.md), | ||
| [io.js](doc/changelogs/CHANGELOG_IOJS.md) and [Archive](doc/changelogs/CHANGELOG_ARCHIVE.md) |
There was a problem hiding this comment.
Should this line (mostly the io.js part) also technically be inserted between 0.12 and v4?
mscdex
reviewed
Oct 31, 2017
CHANGELOG.md
Outdated
| * [Node.js 5](doc/changelogs/CHANGELOG_V5.md), | ||
| * [Node.js 4](doc/changelogs/CHANGELOG_V4.md) | ||
| [0.12](doc/changelogs/CHANGELOG_V012.md), | ||
| [0.10](doc/changelogs/CHANGELOG_V010.md), |
There was a problem hiding this comment.
These two lines should probably be prefixed with 'Node.js' also.
gireeshpunathil
approved these changes
Oct 31, 2017
lpinca
approved these changes
Oct 31, 2017
gibfahn
force-pushed
the
changelog-nit
branch
from
869ed8c
to
43d8a0c
Compare
|
@mscdex updated, PTAL |
apapirovski
approved these changes
Oct 31, 2017
mscdex
reviewed
Oct 31, 2017
CHANGELOG.md
Outdated
| [io.js](doc/changelogs/CHANGELOG_IOJS.md) and [Archive](doc/changelogs/CHANGELOG_ARCHIVE.md) | ||
| * [Node.js 4](doc/changelogs/CHANGELOG_V4.md) | ||
| * [io.js](doc/changelogs/CHANGELOG_IOJS.md) | ||
| * [Node.js 0.12](doc/changelogs/CHANGELOG_V012.md), |
There was a problem hiding this comment.
We can remove these commas now.
gibfahn
force-pushed
the
changelog-nit
branch
from
43d8a0c
to
0894f53
Compare
mscdex
reviewed
Oct 31, 2017
CHANGELOG.md
Outdated
| @@ -9,11 +9,12 @@ Select a Node.js version below to view the changelog history: | |||
| * [Node.js 8](doc/changelogs/CHANGELOG_V8.md) | |||
| * [Node.js 7](doc/changelogs/CHANGELOG_V7.md) | |||
| * [Node.js 6](doc/changelogs/CHANGELOG_V6.md) | |||
| * [Node.js 4](doc/changelogs/CHANGELOG_V4.md) | |||
| * [Node.js 5](doc/changelogs/CHANGELOG_V5.md), | |||
There was a problem hiding this comment.
This comma still needs to be removed.
gibfahn
force-pushed
the
changelog-nit
branch
from
0894f53
to
f181e17
Compare
|
LGTM |
tniessen
approved these changes
Nov 1, 2017
XadillaX
approved these changes
Nov 2, 2017
|
Landed in 94b2be7. |
XadillaX
pushed a commit
that referenced
this pull request
Nov 2, 2017
PR-URL: #16632 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Brian White <mscdex@mscdex.net>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16632 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Brian White <mscdex@mscdex.net>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16632 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Brian White <mscdex@mscdex.net>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
PR-URL: nodejs#16632 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16632 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc