Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update AUTHORS list #16571

Merged
merged 1 commit into from
Nov 21, 2017
Merged

doc: update AUTHORS list #16571

merged 1 commit into from
Nov 21, 2017

Conversation

targos
Copy link
Member

@targos targos commented Oct 28, 2017

Checklist

For people who have their GitHub handle as name, I picked their real name from the GitHub profile (if present). Should we ping them to ask if that's fine?

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 28, 2017
@@ -278,13 +321,17 @@ Tarun Batra <tarun.batra00@gmail.com> Tarun <tarun.batra00@gmail.com>
Ted Young <ted@radicaldesigns.org>
Thomas Lee <thomas.lee@shinetech.com> <tom@tom-debian.sensis.com.au>
Thomas Reggi <thomas@reggi.com>
Tierney Cyren <hello@bnb.im> &! (bitandbang) <tieliaco@gmail.com>
Tierney Cyren <hello@bnb.im> bitandbang <hello@bnb.im>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnb is this correct? The first email address is linked to another account (TierneyC)

Ali Groening <ali.groening@gmail.com>
Mike Fleming <flemingatx@gmail.com>
WeiPlanet <xwjiang@gmail.com>
243083df <243083df@dispostable.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this account can be stolen via the publicly visible disposable email address.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what can we do?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, remove? edit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I if just remove it, it will appear again next time.
I can add it to .mailmap as "Anonymous".

@targos
Copy link
Member Author

targos commented Nov 13, 2017

I just rebased and ran the script again, PTAL

@targos
Copy link
Member Author

targos commented Nov 18, 2017

Updated again.

Ping anyone: please review ;)

PR-URL: nodejs#16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos merged commit 334a7aa into nodejs:master Nov 21, 2017
@targos targos deleted the update-authors branch November 21, 2017 14:50
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #16571
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants