Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: add emitExperimentalWarning function #16497

Closed
wants to merge 1 commit into from
Closed

process: add emitExperimentalWarning function #16497

wants to merge 1 commit into from

Conversation

codeman869
Copy link
Contributor

Adds process.emitExperimentalWarning to inform users that they are
using an experimental feature and that feature can change at any time.
Modifies the ESM module loader warning to utilize the new function and
allows user code to intercept this warning through a setImmediate call.

Refs: #9036

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

process, internal

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. process Issues and PRs related to the process subsystem. labels Oct 25, 2017
mhdawson
mhdawson approved these changes Oct 25, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me to common this up. I'll look at using it for N-API if possible once it lands.

jasnell
jasnell previously approved these changes Oct 26, 2017
View reviewed changes
@jasnell jasnell dismissed their stale review October 26, 2017 14:24

on second thought....

@jasnell
Copy link
Member

jasnell commented Oct 26, 2017

Let's make this an internal function on internal/util rather than expose it on process. It does not need to be a public, general use API.

@codeman869
Copy link
Contributor Author

@jasnell I've moved the changes to internal/util. Let me know what you think

@codeman869
Copy link
Contributor Author

@jasnell do we need any further approvals or anything else to land this PR? :)

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11449/

@codeman869
internal: add emitExperimentalWarning function
81dc7ff 
Adds a new emitExperimentalWarning function to internal/util to warn
users that they are using an experimental feature and that feature can
change at any time.

Refs: nodejs#9036
@codeman869
Copy link
Contributor Author

Rebased commit off current master so hopefully CI would pass

@BridgeAR
Copy link
Member

New CI https://ci.nodejs.org/job/node-test-pull-request/11667/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2017
targos
targos approved these changes Nov 23, 2017
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

landing...

@targos
Copy link
Member

targos commented Nov 23, 2017

Landed in b08c732

@targos targos closed this Nov 23, 2017
targos pushed a commit that referenced this pull request Nov 23, 2017
@codeman869 @targos
internal: add emitExperimentalWarning function
b08c732 
Adds a new emitExperimentalWarning function to internal/util to warn
users that they are using an experimental feature and that feature can
change at any time.

PR-URL: #16497
Refs: #9036
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codeman869 codeman869 deleted the process/experimental branch November 26, 2017 15:40
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
@apapirovski apapirovski mentioned this pull request Dec 8, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@codeman869 @MylesBorins
internal: add emitExperimentalWarning function
6cd7c79 
Adds a new emitExperimentalWarning function to internal/util to warn
users that they are using an experimental feature and that feature can
change at any time.

PR-URL: #16497
Refs: #9036
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@codeman869 @MylesBorins
internal: add emitExperimentalWarning function
8fd316f 
Adds a new emitExperimentalWarning function to internal/util to warn
users that they are using an experimental feature and that feature can
change at any time.

PR-URL: #16497
Refs: #9036
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
@gibfahn gibfahn added semver-minor PRs that contain new features and should be released in the next minor version. and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Dec 19, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@codeman869 @gibfahn
internal: add emitExperimentalWarning function
b1bfced 
Adds a new emitExperimentalWarning function to internal/util to warn
users that they are using an experimental feature and that feature can
change at any time.

PR-URL: #16497
Refs: #9036
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@codeman869 @gibfahn
internal: add emitExperimentalWarning function
e6a568b 
Adds a new emitExperimentalWarning function to internal/util to warn
users that they are using an experimental feature and that feature can
change at any time.

PR-URL: #16497
Refs: #9036
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@apapirovski apapirovski mentioned this pull request Apr 13, 2018
Closed
@richardlau richardlau mentioned this pull request Nov 5, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@codeman869 @jasnell @joyeecheung @BridgeAR @targos @mhdawson @addaleax @gibfahn @nodejs-github-bot