Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: migrate crypto.randomBytes to internal/errors #16454

Closed
wants to merge 1 commit into from
Closed

crypto: migrate crypto.randomBytes to internal/errors #16454

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 24, 2017

Previously had migrated randomBytesFill, this gives the same treatment to crypto.randomBytes()

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@jasnell jasnell added crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. labels Oct 24, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Oct 24, 2017
@jasnell
Copy link
Member Author

jasnell commented Oct 25, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10946/

@jasnell
Copy link
Member Author

jasnell commented Oct 25, 2017

ping @nodejs/tsc

@jasnell
Copy link
Member Author

jasnell commented Oct 25, 2017

CI failures are unrelated

jasnell added a commit that referenced this pull request Oct 26, 2017
@jasnell
crypto: migrate crypto.randomBytes to internal/errors
0a03e35 
PR-URL: #16454
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Oct 26, 2017

Landed in 0a03e35

@jasnell jasnell closed this Oct 26, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@jasnell @addaleax
crypto: migrate crypto.randomBytes to internal/errors
1e8222a 
PR-URL: nodejs/node#16454
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@sehrope sehrope mentioned this pull request Nov 5, 2017
Closed
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@jasnell @addaleax
crypto: migrate crypto.randomBytes to internal/errors
f0ef3f6 
PR-URL: nodejs/node#16454
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@tniessen tniessen mentioned this pull request Dec 10, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @apapirovski @lpinca @targos @joyeecheung @nodejs-github-bot