deps: update V8 to 6.2.414.33 #16412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
ofrobots
approved these changes
Oct 23, 2017
|
Thank you. Landed in d4033c1. |
targos
added a commit
that referenced
this pull request
Oct 26, 2017
Refs: v8/v8@6.2.414.32...6.2.414.33 PR-URL: #16412 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
targos
added a commit
to targos/node
that referenced
this pull request
Oct 26, 2017
This reverts commit d4033c1. Ref: nodejs#16412
|
I'm sorry, I think I didn't correctly checked the CI result. This commit apparently breaks cross-compilation. |
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
Refs: v8/v8@6.2.414.32...6.2.414.33 PR-URL: nodejs/node#16412 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
This reverts commit d4033c15475ff854b645751025135f7899890fcd. The commit broke cross-compilation and it was missed. PR-URL: nodejs/node#16513 Refs: nodejs/node#16412 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Refs: v8/v8@6.2.414.32...6.2.414.33 PR-URL: nodejs/node#16412 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
This reverts commit d4033c15475ff854b645751025135f7899890fcd. The commit broke cross-compilation and it was missed. PR-URL: nodejs/node#16513 Refs: nodejs/node#16412 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@6.2.414.32...6.2.414.33
/cc @nodejs/v8
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8
CI: https://ci.nodejs.org/job/node-test-pull-request/10925/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1015/