Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tty: fix 'resize' event regression #16225

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Commits on Nov 15, 2017

  1. tty: fix 'resize' event regression

    It's not wholly clear what commit introduced the regression but between
    v8.4.0 and v8.5.0 the 'resize' event stopped getting emitted when the
    tty was resized.
    
    The SIGWINCH event listener apparently was being installed before the
    support code for `process.on('SIGWINCH', ...)` was.  Fix that by moving
    said support code to real early in the bootstrap process.
    
    This commit also seems to fix a Windows-only "write EINVAL" error for
    reasons even less well-understood...
    
    Fixes: nodejs#16141
    Fixes: nodejs#16194
    PR-URL: nodejs#16225
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
    bnoordhuis committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    9c1b18a View commit details
    Browse the repository at this point in the history