Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix deprecation code #15668

Closed
wants to merge 1 commit into from
Closed

repl: fix deprecation code #15668

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This slipped through while landing.
Ref: #15136

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

repl

@BridgeAR
repl: fix deprecation code
bea2d58 
This slipped through while landing.
Ref: nodejs#15136
@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Sep 28, 2017
@hiroppy
Copy link
Member

hiroppy commented Sep 30, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10350/

@BridgeAR
Copy link
Member Author

BridgeAR commented Oct 1, 2017

Landed in da40050

@BridgeAR BridgeAR closed this Oct 1, 2017
BridgeAR added a commit that referenced this pull request Oct 1, 2017
@BridgeAR
repl: fix deprecation code
da40050 
This slipped through while landing.

PR-URL: #15668
Refs: #15136
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@BridgeAR @addaleax
repl: fix deprecation code
76f2ea2 
This slipped through while landing.

PR-URL: nodejs/node#15668
Refs: nodejs/node#15136
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@BridgeAR BridgeAR deleted the fix-deprecation branch April 1, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@princejwesley princejwesley princejwesley approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@BridgeAR @hiroppy @jasnell @addaleax @lpinca @TimothyGu @princejwesley @cjihrig @MylesBorins @nodejs-github-bot