Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream_base: dispatch reqs in the stream impl #1558

Closed
wants to merge 2 commits into from
Closed

stream_base: dispatch reqs in the stream impl #1558

wants to merge 2 commits into from

Commits on Apr 29, 2015

  1. stream_base: dispatch reqs in the stream impl 

    Dispatch requests in the implementation of the stream, not in the code
creating these requests. The requests might be piled up and invoked
internally in the implementation, so it should know better when it is
the time to dispatch them.

In fact, TLS was doing exactly this thing which led us to...

Fix: nodejs#1512
    @indutny
    indutny committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    5138d07 View commit details
    Browse the repository at this point in the history

  2. tls: ensure no synchronous callbacks 

    Make sure that no WriteItem's callback will be invoked synchronously.
Doing so may lead to the use of uninitialized `req` object, or even
worse use-after-free in the caller code.

Fix: nodejs#1512
    @indutny
    indutny committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    af885a4 View commit details
    Browse the repository at this point in the history