tls,doc: fix unallocated deprecation code #15534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation was landed using `DEP00XX` instead of a properly allocated deprecation code.
ChALkeR
approved these changes
Sep 21, 2017
BridgeAR
approved these changes
Sep 21, 2017
|
No worries! :) |
refack
approved these changes
Sep 21, 2017
cjihrig
approved these changes
Sep 21, 2017
lpinca
approved these changes
Sep 22, 2017
|
Landed in 193926e |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 24, 2017
Deprecation was landed using `DEP00XX` instead of a properly allocated deprecation code. PR-URL: #15534 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Marking don't land as I fixed this when cherry-picking the original commit. |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
Deprecation was landed using `DEP00XX` instead of a properly allocated deprecation code. PR-URL: nodejs/node#15534 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation was landed using
DEP00XXinstead of a properlyallocated deprecation code.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tls,doc