build: don't fail make test on source tarballs
#15441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tries to achieve the same effect as nodejs#13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! Fixes: nodejs#14513
nodejs-github-bot
added
build
|
cc/ @jellelicht @vsemozhetbyt @joaocgreis, is this a reasonable compromise? |
vsemozhetbyt
approved these changes
Sep 17, 2017
|
I would be extremely happy if this is merged 👍 |
refack
approved these changes
Sep 18, 2017
jasnell
approved these changes
Sep 21, 2017
|
Landed in 66e45b8 |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 21, 2017
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This should be backported to 6.x, as it's essentially a fix for people using |
|
Also @BridgeAR this landed without CI. |
3 tasks
|
@gibfahn right, that slipped through. I make sure it will run next time. |
lukaszewczak
pushed a commit
to lukaszewczak/node
that referenced
this pull request
Sep 23, 2017
Tries to achieve the same effect as nodejs#13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: nodejs#15441 Fixes: nodejs#14513 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 23, 2017
Tries to achieve the same effect as nodejs/node#13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: nodejs/node#15441 Fixes: nodejs/node#14513 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 25, 2017
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
cherry-picked cleanly @gibfahn |
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: #15441 Fixes: #14513 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to achieve the same effect as #13658 without breaking source tarballs. Presumably if
tools/eslintwasn't there at all, people would notice in the PR review!Fixes: #14513
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build