Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "inspector: rewrite inspector test helper" #14777

Closed
wants to merge 1 commit into from
Closed

Revert "inspector: rewrite inspector test helper" #14777

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This reverts commit 2296b67.

That commit was landed without a green CI and is failing on Windows.

Ref: #14460

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@addaleax
Revert "inspector: rewrite inspector test helper"
42d8d32 
This reverts commit 2296b67.

That commit was landed without a green CI and is failing on Windows.

Ref: nodejs#14460
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Aug 11, 2017
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/11711/

@addaleax addaleax mentioned this pull request Aug 11, 2017
Merged
3 tasks
@addaleax
Copy link
Member Author

CI is back to green, landed in a6973a3

@addaleax addaleax closed this Aug 11, 2017
@addaleax addaleax deleted the revert-inspector branch August 11, 2017 20:36
addaleax added a commit that referenced this pull request Aug 11, 2017
@addaleax
Revert "inspector: rewrite inspector test helper"
a6973a3 
This reverts commit 2296b67.

That commit was landed without a green CI and is failing on Windows.

Ref: #14460
PR-URL: #14777
Reviewed-By: Refael Ackermann <refack@gmail.com>
@eugeneo
Copy link
Contributor

eugeneo commented Aug 11, 2017

Windows CI was green: https://ci.nodejs.org/job/node-test-pull-request/9603/

There was a failure in OS X that was not relevant to that PR.

@eugeneo
Copy link
Contributor

eugeneo commented Aug 11, 2017

Ooops, looks like at some point I messed up CI id, probably during the copy/paste! The CI seems to be for a wrong commit. I am really sorry.

@addaleax
Copy link
Member Author

@eugeneo Yeah, no problem, just open a new PR with the changes :)

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @eugeneo @refack @nodejs-github-bot