Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: stop support building addons with VS 2013 #14764

Closed
wants to merge 1 commit into from
Closed

build: stop support building addons with VS 2013 #14764

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Aug 11, 2017

With this we won't have to float a patch in future V8 upgrades.
Ref: #14730 (comment)

/cc @nodejs/platform-windows @nodejs/ctc

Checklist

@targos targos added build Issues and PRs related to build files or the CI. semver-major PRs that contain breaking changes and should be released in the next major version. windows Issues and PRs related to the Windows platform. labels Aug 11, 2017
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 11, 2017
bnoordhuis
bnoordhuis approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@targos targos added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 11, 2017
tniessen
tniessen approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself LGTM

refack
refack approved these changes Aug 11, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: Don't land in 8

@refack refack added the addons Issues and PRs related to native addons. label Aug 11, 2017
@gibfahn
Copy link
Member

gibfahn commented Aug 11, 2017

Reminder: Don't land in 8

They should be redundant, but adding the labels anyway.

targos added a commit to targos/node that referenced this pull request Aug 18, 2017
@targos
build: stop support building addons with VS 2013
2062a69 
PR-URL: nodejs#14764
Refs: nodejs#14730 (comment)
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos
Copy link
Member Author

targos commented Aug 18, 2017

Landed in 2062a69

@targos targos closed this Aug 18, 2017
@targos targos deleted the bye-vs2013 branch August 18, 2017 08:47
@richardlau richardlau mentioned this pull request Sep 8, 2017
Closed
@targos targos mentioned this pull request Sep 13, 2017
Closed
@joaocgreis joaocgreis mentioned this pull request Sep 14, 2017
Closed
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@joaocgreis joaocgreis mentioned this pull request Oct 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@targos @gibfahn @refack @bnoordhuis @Trott @lpinca @tniessen @nodejs-github-bot