Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test-benchmark-zlib #14763

Closed
wants to merge 1 commit into from
Closed

test: add test-benchmark-zlib #14763

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 11, 2017

Add minimal test to confirm that zlib benchmarks run.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test zlib benchmark

@Trott
test: add test-benchmark-zlib
bfe1ef5 
Add minimal test to confirm that zlib benchmarks run.
@Trott Trott added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem. labels Aug 11, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 11, 2017
@Trott
Copy link
Member Author

Trott commented Aug 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/9637/

Trott added a commit to Trott/io.js that referenced this pull request Aug 14, 2017
@Trott
test: add test-benchmark-zlib
f417add 
Add minimal test to confirm that zlib benchmarks run.

PR-URL: nodejs#14763
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 14, 2017

Landed in f417add

@Trott Trott closed this Aug 14, 2017
@targos targos mentioned this pull request Sep 3, 2017
Closed
@MylesBorins
Copy link
Contributor

Setting dont-land-on-v8.x as the zlib benchmarks don't exist on 8.x

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@Trott Trott deleted the benchmark-zlib branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aqrln aqrln aqrln approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @MylesBorins @refack @jasnell @cjihrig @aqrln @gibfahn @nodejs-github-bot