Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib: check cleanup return values #14673

Closed
wants to merge 1 commit into from
Closed

zlib: check cleanup return values #14673

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Aug 7, 2017

Tests seem to always pass without #14666, so unfortunately can’t be used as a test for that, but it should still be worth doing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

zlib

@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x zlib Issues and PRs related to the zlib subsystem. labels Aug 7, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem. labels Aug 7, 2017
@addaleax addaleax mentioned this pull request Aug 7, 2017
Closed
2 tasks
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/11688/

This should be ready.

@addaleax
Copy link
Member Author

Landed in 2421984

@addaleax addaleax closed this Aug 10, 2017
@addaleax addaleax deleted the zlib-check-end branch August 10, 2017 20:39
addaleax added a commit that referenced this pull request Aug 10, 2017
@addaleax
zlib: check cleanup return values
2421984 
PR-URL: #14673
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @refack @jasnell @cjihrig @tniessen @nodejs-github-bot