doc: building - note on Windows SDK 15063 #14394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refack
added
build
nodejs-github-bot
added
build
gibfahn
approved these changes
Jul 22, 2017
|
cc/ @nodejs/platform-windows |
seishun
reviewed
Jul 22, 2017
| @@ -170,7 +170,8 @@ Prerequisites: | |||
| including the Community edition (remember to select | |||
| "Common Tools for Visual C++ 2015" feature during installation). | |||
| * [Visual Studio 2017](https://www.visualstudio.com/downloads/), any edition (including the Build Tools SKU). | |||
| **Required Components:** "MSbuild", "VC++ 2017 v141 toolset" and one of the Windows SDKs (10 or 8.1). | |||
| **Required Components:** "MSbuild", "VC++ 2017 v141 toolset" and at least one of the Windows SDKs. | |||
| *Note*: For "Windows 10 SDK (10.0.15063.0)" only the "Desktop C++ x86 and x64" flavor is required. | |||
There was a problem hiding this comment.
I'd drop the "only" since you can't install it without installing the other two.
There was a problem hiding this comment.
Are you sure (I haven't tried VM is giving me trouble)?
joaocgreis
approved these changes
Aug 26, 2017
BridgeAR
approved these changes
Aug 27, 2017
|
My review only counts for the wording. I do not use Windows at all. |
|
Landed in 0babb12 |
BridgeAR
pushed a commit
that referenced
this pull request
Aug 27, 2017
PR-URL: #14394 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#14394 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#14394 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #14394 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #14394 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Windows 10 SDK 15063 there are three flavors. Only one works for building node
Checklist
Affected core subsystem(s)
doc