Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSConf CN Code&Learn]test: replace string concatenation with template literals #14283

Closed
wants to merge 4 commits into from
Closed

[JSConf CN Code&Learn]test: replace string concatenation with template literals #14283

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5369493
replace string concatenation in test/parallel/test-child-process-cons…
Jul 16, 2017
7751588
follow reviewed suggestion to split at the sentence break
Jul 16, 2017
ada1399
Change keeping the one concatenation and indenting for readability
Jul 16, 2017
e49daaa
Align the Received part with the The "options" part
Jul 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/parallel/test-child-process-constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ function typeName(value) {
}, common.expectsError({
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "options" argument must be of type object. Received type ' +
typeName(options)
message: 'The "options" argument must be of type object. ' +
`Received type ${typeName(options)}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align the Received part with the The "options" part :-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell I have fixed the code to align the Received part with the The "options" part

}));
});
}
Expand All @@ -35,8 +35,8 @@ function typeName(value) {
}, common.expectsError({
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "options.file" property must be of type string. Received ' +
'type ' + typeName(file)
message: 'The "options.file" property must be of type string. ' +
`Received type ${typeName(file)}`
}));
});
}
Expand All @@ -52,7 +52,7 @@ function typeName(value) {
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "options.envPairs" property must be of type array. ' +
'Received type ' + typeName(envPairs)
`Received type ${typeName(envPairs)}`
}));
});
}
Expand All @@ -67,8 +67,8 @@ function typeName(value) {
}, common.expectsError({
code: 'ERR_INVALID_ARG_TYPE',
type: TypeError,
message: 'The "options.args" property must be of type array. Received ' +
'type ' + typeName(args)
message: 'The "options.args" property must be of type array. ' +
`Received type ${typeName(args)}`
}));
});
}
Expand Down