test: replace concatenation with template literals. #14281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
the
code-and-learn
TimothyGu
added
code-and-learn
Trott
requested changes
Jul 16, 2017
| @@ -218,8 +218,7 @@ function checkFormat(path, testCases) { | |||
| }, common.expectsError({ | |||
| code: 'ERR_INVALID_ARG_TYPE', | |||
| type: TypeError, | |||
| message: 'The "pathObject" argument must be of type Object. Received ' + | |||
| 'type ' + typeName(pathObject) | |||
| message: `The "pathObject" argument must be of type Object. Received type ${typeName(pathObject)}` | |||
There was a problem hiding this comment.
Does this get flagged as too long when you run make jslint (or vcbuild jslint on Windows)?
If so, maybe it can be split onto two lines?:
message: 'The "pathObject" argument must be of type Object. ' +
`Received type ${typeName(pathObject)}`;It only gets rid of one of the concatenations rather than both that way, but I'm not sure there's a good way around it with the line length limit.
xeodou
force-pushed
the
test-path-parse-format
branch
from
0bee10a
to
4c61fdb
Compare
|
/ping @Trott The change is fixed. |
gibfahn
approved these changes
Jul 16, 2017
cjihrig
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
|
CI was green but I canceled some of the slower hosts to help with our CI jobs backlog. IMO this can be considered green CI. |
gireeshpunathil
approved these changes
Jul 17, 2017
|
@gireeshpunathil Even though I agree, that is out of the scope of this PR. These error messages are generated automatically by |
jasnell
approved these changes
Jul 17, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 24, 2017
PR-URL: nodejs#14281 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 3566195 Thanks for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)