net: support passing undefined to listen() #14234

sam-github · 2017-07-14T18:11:08Z

For consistency with 4.x and 8.x.

This commit also contains a forward port of
#14232 to confirm that 4.x and 6.x
behave identically with respect to the port argument.

Ref: #14205

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

sam-github · 2017-07-14T18:15:44Z

@cjihrig What was happening is that assertPort() explicitly allows undefined as a valid value. However, toNumber() did not, and was converting undefined to false, and that then got passed to assertPort(), and threw. I think I fixed this in the right place, but perhaps you have other suggestions.

sam-github · 2017-07-14T18:16:49Z

@nodejs/lts PTAL, this is the LTS part of the fix for #14205

lpinca · 2017-07-14T20:13:25Z

test/parallel/test-net-listen-port-option.js

+  -1 / 0,
+].forEach(function(port) {
+  assert.throws(function() {
+    net.Server().listen({ port: port }, common.fail);


This first argument should be port not an object.

jasnell · 2017-07-17T15:35:36Z

test/parallel/test-net-listen-port-option.js

+
+net.Server().listen(true).on('error', common.mustCall(function(err) {
+  assert.strictEqual(err.code, 'EACCES');
+}));


fwiw, this can be simplified to ....

net.Server().listen(true).on('error', common.expectsError({ code: 'EACCES' }));

expectsError doesn't exist on 6.x, AFAICT

ah! heh... good point ;-)

sam-github · 2017-07-17T16:51:11Z

@nodejs/lts PTAL

sam-github · 2017-07-17T16:52:36Z

ci: https://ci.nodejs.org/job/node-test-pull-request/9194/

gibfahn · 2017-07-18T05:28:32Z

@sam-github is this semver-minor? I guess if it restores previous behaviour that was then broken it's a bugfix.

MylesBorins · 2017-07-18T19:26:15Z

Waiting on confirmation if this is a bugfix or not. It will likely not make the v6.11.2-rc today, but willing to roll it into the next rc later this week if it is indeed a patch

sam-github · 2017-07-18T20:45:54Z

@MylesBorins This is a bug fix, see #14205 (comment), undefined could be passed in 4.x and 8.x, but can't in 6.x.

I want to land, but do I need one approval, or two? @cjihrig is the domain expert here and approved it, maybe his LGTM is all I need?

jasnell · 2017-07-19T21:05:39Z

I agree with bug fix.

For consistency with 4.x and 8.x. This commit also contains a forward port of #14232 to confirm that 4.x and 6.x behave identically with respect to the port argument. PR-URL: #14234 Refs: #14205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

sam-github · 2017-07-21T16:04:09Z

Landed in 0b17a45

For consistency with 4.x and 8.x. This commit also contains a forward port of #14232 to confirm that 4.x and 6.x behave identically with respect to the port argument. PR-URL: #14234 Refs: #14205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

MylesBorins · 2017-07-31T04:11:34Z

@sam-github This seems to be breaking windows CI so I'm backing it out of v6.11.2 for now

https://ci.nodejs.org/job/node-test-binary-windows/10189/RUN_SUBSET=0,VS_VERSION=vcbt2015,label=win10/

edit: for clarity I'm keeping it on staging for now, please let me know if you can figure out why we are getting time outs

For consistency with 4.x and 8.x. This commit also contains a forward port of #14232 to confirm that 4.x and 6.x behave identically with respect to the port argument. PR-URL: #14234 Refs: #14205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

MylesBorins · 2017-08-12T00:11:45Z

I'm backing this out of staging as the broken test is blocking CI on other PRS.

@sam-github please reopen, rebase, and try to get this passing on windows.

edit: here is a gist of the patch as you may have deleted the branch and links above could be removed in cache flush

https://gist.github.com/MylesBorins/f5ab7d9a23126c13c36ead9b2fa64f92

MylesBorins · 2017-08-16T07:55:25Z

ping @sam-github just a reminder this got backed out. I can't reopen this as you deleted your branch

sam-github · 2017-08-16T19:21:54Z

@MylesBorins restored branch, won't have time to look more at it until I'm back from vacation

MylesBorins · 2017-09-19T12:58:55Z

@nodejs/lts thoughts?

jasnell · 2017-09-19T13:13:15Z

Thoughts on what exactly? The test is still failing on Windows, correct? I'm good with this landing once that it resolved.

sam-github · 2017-09-19T16:23:48Z

I'm baffled that this has windows specific behaviour, and I'm looking into it.

starting with re-running ci: https://ci.nodejs.org/job/node-test-pull-request/10136/

sam-github · 2017-09-19T21:16:18Z

I figured this out, it's because net.Server().listen(1) works on Windows. I'll fix the test.

sam-github · 2017-09-19T21:59:06Z

ci: https://ci.nodejs.org/job/node-test-pull-request/10145/

For consistency with 4.x and 8.x. This commit also contains a forward port of nodejs#14232 to confirm that 4.x and 6.x behave identically with respect to the port argument. PR-URL: nodejs#14234 Refs: nodejs#14205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

sam-github · 2017-09-19T23:57:50Z

@MylesBorins last ci passed except for lint (fixed) and arm (probably broken), this should pass:

ci: https://ci.nodejs.org/job/node-test-pull-request/10148/

MylesBorins · 2017-09-20T12:44:30Z

landed in caeee38

For consistency with 4.x and 8.x. This commit also contains a forward port of #14232 to confirm that 4.x and 6.x behave identically with respect to the port argument. Backport-PR-URL: #14234 PR-URL: #14234 Refs: #14205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

MylesBorins · 2017-09-22T19:01:36Z

@cjihrig should we hold off on landing this until the bugs are all fixed in 8.x?

cjihrig · 2017-09-22T19:19:17Z

Just reiterating from IRC. I believe this should stay in the release if everything is passing. The bugs on 8.x in question are slightly different (#14205 (comment)).

Notable Changes: * net: - support passing undefined to listen() to match behavior in v4.x and v8.x (Sam Roberts) #14234 PR-URL: #15506

Notable Changes: * net: - support passing undefined to listen() to match behavior in v4.x and v8.x (Sam Roberts) nodejs/node#14234 PR-URL: nodejs/node#15506

nodejs-github-bot added net Issues and PRs related to the net subsystem. v6.x labels Jul 14, 2017

This was referenced Jul 14, 2017

test: check allowed port argument values #14232

Closed

net: support passing null to listen() #14221

Merged

lpinca reviewed Jul 14, 2017

View reviewed changes

cjihrig approved these changes Jul 15, 2017

View reviewed changes

jasnell reviewed Jul 17, 2017

View reviewed changes

sam-github force-pushed the fix-listen-on-undefined branch from a1bbca6 to efa1a33 Compare July 17, 2017 16:50

jasnell approved these changes Jul 19, 2017

View reviewed changes

sam-github force-pushed the fix-listen-on-undefined branch from 8c378b6 to 6580202 Compare July 21, 2017 00:23

sam-github closed this Jul 21, 2017

sam-github deleted the fix-listen-on-undefined branch July 21, 2017 16:06

MylesBorins mentioned this pull request Jul 21, 2017

v6.11.2 proposal #14356

Merged

sam-github restored the fix-listen-on-undefined branch August 16, 2017 19:21

MylesBorins reopened this Aug 16, 2017

MylesBorins force-pushed the v6.x-staging branch 2 times, most recently from aaf4e13 to 31f572c Compare September 5, 2017 16:50

BridgeAR added the wip Issues and PRs that are still a work in progress. label Sep 13, 2017

sam-github force-pushed the fix-listen-on-undefined branch 2 times, most recently from 39c381c to 8c25a95 Compare September 19, 2017 16:20

sam-github force-pushed the fix-listen-on-undefined branch from 8c25a95 to 739a404 Compare September 19, 2017 21:31

sam-github force-pushed the fix-listen-on-undefined branch from d1a1331 to e925c97 Compare September 19, 2017 23:54

MylesBorins closed this Sep 20, 2017

sam-github deleted the fix-listen-on-undefined branch September 20, 2017 15:42

MylesBorins mentioned this pull request Sep 20, 2017

v6.11.4 proposal #15506

Merged

MylesBorins added a commit that referenced this pull request Oct 3, 2017

2017-10-03, Version 6.11.4 'Boron' (LTS)

8691fdf

Notable Changes: * net: - support passing undefined to listen() to match behavior in v4.x and v8.x (Sam Roberts) #14234 PR-URL: #15506

MylesBorins added a commit that referenced this pull request Oct 3, 2017

2017-10-03, Version 6.11.4 'Boron' (LTS)

9e8f4b3

Notable Changes: * net: - support passing undefined to listen() to match behavior in v4.x and v8.x (Sam Roberts) #14234 PR-URL: #15506

addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017

2017-10-03, Version 6.11.4 'Boron' (LTS)

f51fbea

Notable Changes: * net: - support passing undefined to listen() to match behavior in v4.x and v8.x (Sam Roberts) nodejs/node#14234 PR-URL: nodejs/node#15506

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: support passing undefined to listen() #14234

net: support passing undefined to listen() #14234

sam-github commented Jul 14, 2017

sam-github commented Jul 14, 2017

sam-github commented Jul 14, 2017

lpinca Jul 14, 2017 •

edited

Loading

jasnell Jul 17, 2017

sam-github Jul 17, 2017

jasnell Jul 19, 2017

sam-github commented Jul 17, 2017 •

edited by gibfahn

Loading

sam-github commented Jul 17, 2017

gibfahn commented Jul 18, 2017 •

edited

Loading

MylesBorins commented Jul 18, 2017

sam-github commented Jul 18, 2017

jasnell commented Jul 19, 2017

sam-github commented Jul 21, 2017

MylesBorins commented Jul 31, 2017 •

edited

Loading

MylesBorins commented Aug 12, 2017 •

edited

Loading

MylesBorins commented Aug 16, 2017

sam-github commented Aug 16, 2017

MylesBorins commented Sep 19, 2017

jasnell commented Sep 19, 2017

sam-github commented Sep 19, 2017

sam-github commented Sep 19, 2017

sam-github commented Sep 19, 2017

sam-github commented Sep 19, 2017

MylesBorins commented Sep 20, 2017 •

edited

Loading

MylesBorins commented Sep 22, 2017

cjihrig commented Sep 22, 2017

net: support passing undefined to listen() #14234

net: support passing undefined to listen() #14234

Conversation

sam-github commented Jul 14, 2017

Checklist

Affected core subsystem(s)

sam-github commented Jul 14, 2017

sam-github commented Jul 14, 2017

lpinca Jul 14, 2017 • edited Loading

Choose a reason for hiding this comment

jasnell Jul 17, 2017

Choose a reason for hiding this comment

sam-github Jul 17, 2017

Choose a reason for hiding this comment

jasnell Jul 19, 2017

Choose a reason for hiding this comment

sam-github commented Jul 17, 2017 • edited by gibfahn Loading

sam-github commented Jul 17, 2017

gibfahn commented Jul 18, 2017 • edited Loading

MylesBorins commented Jul 18, 2017

sam-github commented Jul 18, 2017

jasnell commented Jul 19, 2017

sam-github commented Jul 21, 2017

MylesBorins commented Jul 31, 2017 • edited Loading

MylesBorins commented Aug 12, 2017 • edited Loading

MylesBorins commented Aug 16, 2017

sam-github commented Aug 16, 2017

MylesBorins commented Sep 19, 2017

jasnell commented Sep 19, 2017

sam-github commented Sep 19, 2017

sam-github commented Sep 19, 2017

sam-github commented Sep 19, 2017

sam-github commented Sep 19, 2017

MylesBorins commented Sep 20, 2017 • edited Loading

MylesBorins commented Sep 22, 2017

cjihrig commented Sep 22, 2017

lpinca Jul 14, 2017 •

edited

Loading

sam-github commented Jul 17, 2017 •

edited by gibfahn

Loading

gibfahn commented Jul 18, 2017 •

edited

Loading

MylesBorins commented Jul 31, 2017 •

edited

Loading

MylesBorins commented Aug 12, 2017 •

edited

Loading

MylesBorins commented Sep 20, 2017 •

edited

Loading