Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix off-by-one indentation #14064

Closed
wants to merge 1 commit into from
Closed

lib: fix off-by-one indentation #14064

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 3, 2017

In preparation for more robust indentation linting, fix an off-by-one
indentation in lib/http_server.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

@Trott
lib: fix off-by-one indentation
1d568fb 
In preparation for more robust indentation linting, fix an off-by-one
indentation in lib/http_server.js.
@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 3, 2017
addaleax
addaleax approved these changes Jul 3, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t need to wait 48 hours

@Trott
Copy link
Member Author

Trott commented Jul 3, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/8972/

@Trott
Copy link
Member Author

Trott commented Jul 4, 2017

Landed in a577bde

@Trott Trott closed this Jul 4, 2017
Trott added a commit to Trott/io.js that referenced this pull request Jul 4, 2017
@Trott
lib: fix off-by-one indentation
a577bde 
In preparation for more robust indentation linting, fix an off-by-one
indentation in lib/http_server.js.

PR-URL: nodejs#14064
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@Trott Trott deleted the lib-fix branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @fhinkel @addaleax @lpinca @targos @cjihrig @tniessen @vsemozhetbyt @nodejs-github-bot