src: unset NODE_VERSION_IS_RELEASE
#14005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 53b8c51 was cherry-picked into `master`, `NODE_VERSION_IS_RELEASE` was accidentally set to `1` as well.
|
herp derp, I could swear that I manually undid this! lgtm |
|
+1 to fast-track, get it done |
addaleax
added
dont-land-on-v6.x
lib / src
|
Landed in a84c3be, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 53b8c51 was cherry-picked into
master,NODE_VERSION_IS_RELEASEwas accidentally set to1as well.I’d suggest fast-tracking because it’s a trivial change and fixes the version reported by nightlies/builds off
master.