Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: disable fast math on arm #1398

Merged
merged 2 commits into from
Apr 11, 2015
Merged

src: disable fast math on arm #1398

merged 2 commits into from
Apr 11, 2015

Commits on Apr 11, 2015

  1. src: disable fast math on arm 

    The "fast" implementation of Math.exp() and Math.tanh() emits ARMv7
movt/movw instructions on ARMv6 (notably, the original Raspberry Pi.)

Disable fast math for now.  The adventurous can enable it again with
the --fast_math switch.

PR-URL: nodejs#1398
Refs: nodejs#1376
Reviewed-By: Roman Reiss <me@silverwind.io>
V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019
    @bnoordhuis
    bnoordhuis committed Apr 11, 2015
    Configuration menu
    Copy the full SHA
    e306c78 View commit details
    Browse the repository at this point in the history

  2. src: disable fast math only on armv6 

    Don't disable fast math on ARMv7, only ARMv6.  I hope I got all the
v6 subarchs.

PR-URL: nodejs#1398
Reviewed-By: Roman Reiss <me@silverwind.io>
    @bnoordhuis
    bnoordhuis committed Apr 11, 2015
    Configuration menu
    Copy the full SHA
    a4d8847 View commit details
    Browse the repository at this point in the history