Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix api docs style #13970

Closed
wants to merge 1 commit into from
Closed

doc: fix api docs style #13970

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Jun 28, 2017 •
edited
Loading

Summary
doc/api/cluster.md
  L337: Use the definition link

doc/api/deprecations.md
  L106: Fix the definition link name

doc/api/errors.md
  L901: Remove unused definition
Checklist
  • make -j4 test
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2017
@watilde
doc: fix api docs style
ce11e0c 
doc/api/cluster.md
  L337: Use the definition link

doc/api/deprecations.md
  L106: Fix the definition link name

doc/api/errors.md
  L901: Remove unused definition

PR-URL: nodejs#13970
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
@watilde
Copy link
Member Author

watilde commented Jul 3, 2017

lint ci: https://ci.nodejs.org/job/node-test-linter/10219/

@watilde
Copy link
Member Author

watilde commented Jul 3, 2017

landed in 8b2c61c. thanks.

@watilde watilde closed this Jul 3, 2017
@watilde watilde deleted the feature/docs-style branch July 3, 2017 09:06
watilde added a commit that referenced this pull request Jul 3, 2017
@watilde
doc: fix api docs style
8b2c61c 
doc/api/cluster.md
  L337: Use the definition link

doc/api/deprecations.md
  L106: Fix the definition link name

doc/api/errors.md
  L901: Remove unused definition

PR-URL: #13970
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Cai <davidcai1993@yahoo.com>
@addaleax
Copy link
Member

addaleax commented Jul 3, 2017

Adding dont-land-on-v8.x because it’s a tiny format change and doesn’t apply cleanly, feel free to raise a backport PR if you like.

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@DavidCai1111 DavidCai1111 DavidCai1111 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@watilde @addaleax @jasnell @lpinca @cjihrig @thelostone-mc @DavidCai1111 @MylesBorins @nodejs-github-bot