net: remove net.Socket.prototype.listen #13735

BridgeAR · 2017-06-17T02:39:26Z

~~I suggest to deprecate this function. It was never documented even though it was already added in 2011. I am not sure what it was for and maybe @bnoordhuis might have a look as a original reviewer?~~
The function is defunct and shout simply be removed. As it was never documented there should not be a problem about it.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

net

cjihrig · 2017-06-19T18:02:42Z

lib/net.js

+    debug('socket.listen');
+    this.on('connection', arguments[0]);
+    listenInCluster(this, null, null, null);
+  },


Can you remove the extra indentation, and change this line to:

}, 'Socket.prototype.listen() is deprecated.', 'DEP0073');

The deprecation code should be DEP00XX... the actual value would be assigned when the PR lands

jasnell · 2017-06-19T18:07:10Z

Ping @ChALkeR ... is it possible to get some idea of how much this is used?

bnoordhuis · 2017-06-20T11:47:18Z

Not opposed but it's neither broken nor a maintenance hassle, just a wart.

BridgeAR · 2017-06-20T14:33:38Z

@bnoordhuis would you recommend to document this part instead of deprecating it? Because I think the current situation should be changed one way or the other.

BridgeAR · 2017-06-23T21:55:15Z

PTAL

cjihrig · 2017-06-23T23:45:54Z

@BridgeAR https://github.com/nodejs/node/pull/13735/files#r122780215 still applies I think.

BridgeAR · 2017-06-26T07:55:24Z

@cjihrig sorry, I didn't address the comment right away because I thought there might be feedback to my question. I fixed that now though.

jasnell · 2017-06-26T17:03:06Z

doc/api/deprecations.md

@@ -630,6 +630,14 @@ Type: Runtime

 *Note*: change was made while `async_hooks` was an experimental API.

+<a id="DEP0073"></a>
+### DEP0073: net.Socket.prototype.listen()


The deprecation code here should be DEP00XX. The actual number should be assigned when the PR lands.

BridgeAR · 2017-06-26T21:09:37Z

Comment addressed and rebased

BridgeAR · 2017-08-25T04:49:54Z

PTAL - we might also still just go ahead and document this instead of deprecating it.
(I will rebase as soon as there is a conclusion)

jasnell · 2017-08-25T17:51:44Z

@BridgeAR ... that would be my preference.

BridgeAR · 2017-12-06T00:06:53Z

I am closing this as I do not really know how to document this as I do not know what it should be used for.

If someone knows more, please let me know and I will have a look at it again.

bnoordhuis · 2017-12-06T00:27:18Z

@BridgeAR The idea is that net.Socket#listen() enables process.stdin.listen(), which at one time was necessary to make FastCGI work.

Looking at the code again, I'm pretty sure it's broken (as in: unusable, throws TypeErrors) and has been for a long time so there is no point in deprecating it. It can be removed outright.

BridgeAR · 2017-12-06T16:52:25Z

@bnoordhuis thanks a lot for the info! And yes, I just checked and the function would simple throw a TypeError when called. Removing seems to be the right thing to do here.

The function was never documented and now throws a TypeError if used.

apapirovski · 2017-12-09T20:45:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/12009/

I've also removed the semver-major label as this method doesn't even work.

The function was never documented and now throws a TypeError if used. PR-URL: nodejs#13735 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

BridgeAR · 2017-12-12T14:33:42Z

Landed in e17dba7

The function was never documented and now throws a TypeError if used. PR-URL: #13735 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

Notable change: * async_hooks: - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither API were documented. (Andreas Madsen) #16972 * deps: - update nghttp2 to 1.29.0 (James M Snell) #17908 - upgrade npm to 5.6.0 (Kat Marchán) #17535 - cherry-pick 50f7455 from upstream V8 (Michaël Zasso) #16591 * events: - remove reaches into _events internals (Anatoli Papirovski) #17440 * http: - add rawPacket in err of `clientError` event (XadillaX) #17672 * http2: - implement maxSessionMemory (James M Snell) #17967 - add initial support for originSet (James M Snell) #17935 - add altsvc support (James M Snell) #17917 - perf_hooks integration (James M Snell) #17906 * net: - remove Socket.prototype.write (Anna Henningsen) #17644 - remove Socket.prototype.listen (Ruben Bridgewater) #13735 * repl: - show lexically scoped vars in tab completion (Michaël Zasso) #16591 * stream: - rm {writeable/readable}State.length (Calvin Metcalf) #12857 - add flow and buffer properties to streams (Calvin Metcalf) #12855 * util: - allow wildcards in NODE_DEBUG variable (Tyler) #17609 * zlib: - add ArrayBuffer support (Jem Bezooyen) #16042 * Addedew collaborator** - [starkwang](https://github.com/starkwang) Weijia Wang * Addedew TSC member** - [danbev](https://github.com/danbev) Daniel Bevenius PR-URL: #18069

Notable change: * async_hooks: - deprecate AsyncHooks Sensitive API and runInAsyncIdScope. Neither API were documented. (Andreas Madsen) #16972 * deps: - update nghttp2 to 1.29.0 (James M Snell) #17908 - upgrade npm to 5.6.0 (Kat Marchán) #17535 - cherry-pick 50f7455 from upstream V8 (Michaël Zasso) #16591 * events: - remove reaches into _events internals (Anatoli Papirovski) #17440 * http: - add rawPacket in err of `clientError` event (XadillaX) #17672 * http2: - implement maxSessionMemory (James M Snell) #17967 - add initial support for originSet (James M Snell) #17935 - add altsvc support (James M Snell) #17917 - perf_hooks integration (James M Snell) #17906 - Refactoring and cleanup of Http2Session and Http2Stream destroy (James M Snell) #17406 * net: - remove Socket.prototype.write (Anna Henningsen) #17644 - remove Socket.prototype.listen (Ruben Bridgewater) #13735 * repl: - show lexically scoped vars in tab completion (Michaël Zasso) #16591 * stream: - rm {writeable/readable}State.length (Calvin Metcalf) #12857 - add flow and buffer properties to streams (Calvin Metcalf) #12855 * util: - allow wildcards in NODE_DEBUG variable (Tyler) #17609 * zlib: - add ArrayBuffer support (Jem Bezooyen) #16042 * Addedew collaborator** - [starkwang](https://github.com/starkwang) Weijia Wang * Addedew TSC member** - [danbev](https://github.com/danbev) Daniel Bevenius PR-URL: #18069

MylesBorins · 2018-01-22T08:32:59Z

Didn't land on v6.x, should it be considered for v8.x?

MylesBorins · 2018-05-22T15:55:53Z

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Jun 17, 2017

mscdex added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 17, 2017

cjihrig reviewed Jun 19, 2017

View reviewed changes

ChALkeR self-assigned this Jun 24, 2017

cjihrig approved these changes Jun 26, 2017

View reviewed changes

jasnell reviewed Jun 26, 2017

View reviewed changes

BridgeAR force-pushed the deprecate-socket-listen branch from 9388c56 to 3929c94 Compare June 26, 2017 21:09

BridgeAR closed this Dec 6, 2017

BridgeAR reopened this Dec 6, 2017

BridgeAR force-pushed the deprecate-socket-listen branch from 3929c94 to 12118fd Compare December 6, 2017 16:52

net: remove Socket.prototype.listen

b2fc8da

The function was never documented and now throws a TypeError if used.

BridgeAR force-pushed the deprecate-socket-listen branch from 12118fd to b2fc8da Compare December 6, 2017 16:53

BridgeAR changed the title ~~net: deprecate net.Socket.prototype.listen~~ net: remove net.Socket.prototype.listen Dec 6, 2017

bnoordhuis approved these changes Dec 6, 2017

View reviewed changes

MylesBorins force-pushed the master branch from b7405ab to 7f086dd Compare December 8, 2017 16:37

apapirovski approved these changes Dec 9, 2017

View reviewed changes

apapirovski removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Dec 9, 2017

apapirovski unassigned ChALkeR Dec 9, 2017

apapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2017

BridgeAR closed this Dec 12, 2017

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017

MylesBorins mentioned this pull request Jan 10, 2018

v9.4.0 proposal #18069

Merged

MylesBorins added the dont-land-on-v6.x label Jan 22, 2018

MylesBorins added the backport-requested-v8.x label May 22, 2018

codebytere mentioned this pull request Jun 6, 2018

[v8.x backport] net: remove Socket.prototype.listen #21176

Closed

3 tasks

TimothyGu added dont-land-on-v8.x and removed backport-requested-v8.x labels Jun 11, 2018

BridgeAR deleted the deprecate-socket-listen branch April 1, 2019 23:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

net: remove net.Socket.prototype.listen #13735

net: remove net.Socket.prototype.listen #13735

BridgeAR commented Jun 17, 2017 •

edited

Loading

cjihrig Jun 19, 2017

jasnell Jun 19, 2017

jasnell commented Jun 19, 2017

bnoordhuis commented Jun 20, 2017

BridgeAR commented Jun 20, 2017

BridgeAR commented Jun 23, 2017

cjihrig commented Jun 23, 2017

BridgeAR commented Jun 26, 2017

jasnell Jun 26, 2017

BridgeAR commented Jun 26, 2017

BridgeAR commented Aug 25, 2017

jasnell commented Aug 25, 2017

BridgeAR commented Dec 6, 2017

bnoordhuis commented Dec 6, 2017

BridgeAR commented Dec 6, 2017

apapirovski commented Dec 9, 2017

BridgeAR commented Dec 12, 2017

MylesBorins commented Jan 22, 2018

MylesBorins commented May 22, 2018

net: remove net.Socket.prototype.listen #13735

net: remove net.Socket.prototype.listen #13735

Conversation

BridgeAR commented Jun 17, 2017 • edited Loading

Checklist

Affected core subsystem(s)

cjihrig Jun 19, 2017

Choose a reason for hiding this comment

jasnell Jun 19, 2017

Choose a reason for hiding this comment

jasnell commented Jun 19, 2017

bnoordhuis commented Jun 20, 2017

BridgeAR commented Jun 20, 2017

BridgeAR commented Jun 23, 2017

cjihrig commented Jun 23, 2017

BridgeAR commented Jun 26, 2017

jasnell Jun 26, 2017

Choose a reason for hiding this comment

BridgeAR commented Jun 26, 2017

BridgeAR commented Aug 25, 2017

jasnell commented Aug 25, 2017

BridgeAR commented Dec 6, 2017

bnoordhuis commented Dec 6, 2017

BridgeAR commented Dec 6, 2017

apapirovski commented Dec 9, 2017

BridgeAR commented Dec 12, 2017

MylesBorins commented Jan 22, 2018

MylesBorins commented May 22, 2018

BridgeAR commented Jun 17, 2017 •

edited

Loading