Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update link to Code of Conduct #12552

Closed
wants to merge 1 commit into from
Closed

doc: update link to Code of Conduct #12552

wants to merge 1 commit into from

Conversation

aautem
Copy link
Contributor

@aautem aautem commented Apr 20, 2017

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 20, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 20, 2017 •
edited
Loading

Thank you, @aautem.

Reviewers, let me know if this can be landed sooner.

Also, we may need to report this somehow for deps/node-inspect: https://github.com/nodejs/node/search?q=CODE_OF_CONDUCT&type=Code&utf8=%E2%9C%93

jasnell
jasnell approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! completely forgot about this one!

addaleax
addaleax approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m good with landing early

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Apr 20, 2017
@vsemozhetbyt
Copy link
Contributor

Landed in 8ecb2ca

vsemozhetbyt pushed a commit that referenced this pull request Apr 20, 2017
@aautem @vsemozhetbyt
doc: update link to Code of Conduct
8ecb2ca 
PR-URL: #12552
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@aautem @evanlucas
doc: update link to Code of Conduct
8fc9b9b 
PR-URL: #12552
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@aautem @evanlucas
doc: update link to Code of Conduct
3c595dc 
PR-URL: #12552
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@aautem @evanlucas
doc: update link to Code of Conduct
3703fc6 
PR-URL: #12552
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@aautem @gibfahn
doc: update link to Code of Conduct
828f714 
PR-URL: #12552
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@aautem @MylesBorins
doc: update link to Code of Conduct
278e8cc 
PR-URL: #12552
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@aautem @andrew749
doc: update link to Code of Conduct
a42b4df 
PR-URL: nodejs/node#12552
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aautem @vsemozhetbyt @jasnell @addaleax @cjihrig @mscdex @gibfahn @nodejs-github-bot