Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify real name requirement in CONTRIBUTING.md #1250

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

This should hopefully make it more clear that git's user.name should be set to the real name before committing a pull request. I'm open to suggestions of witty placeholder names ;)

related: #1246
cc: @MayhemYDG

@nstepien
Copy link
Contributor

👍

@Fishrock123
Copy link
Contributor

LGTM

@silverwind silverwind added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. and removed child_process Issues and PRs related to the child_process subsystem. labels Mar 24, 2015
@silverwind silverwind changed the title doc: add real name requirement to CONTRIBUTING.md doc: clarify real name requirement in CONTRIBUTING.md Mar 24, 2015
@silverwind
Copy link
Contributor Author

I think this is a pretty straightforward improvement, going to merge it in right ahead.

@silverwind silverwind self-assigned this Mar 24, 2015
silverwind added a commit that referenced this pull request Mar 24, 2015
CONTRIBUTING.md didn't make our rule for requiring real names from
contributors clear enough. This commit shall clarify that part.

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #1250
@silverwind
Copy link
Contributor Author

merged in 4e9bf93

@silverwind silverwind closed this Mar 24, 2015
@rvagg rvagg mentioned this pull request Mar 25, 2015
@rvagg
Copy link
Member

rvagg commented Mar 25, 2015

Actually I'm -1 on this, it's not straight forward, some people prefer to use pseudonyms and there's no reason to force a real name out of these people, this change could be interpreted as policy.

See #606 for an example for this.

@silverwind
Copy link
Contributor Author

Ah, I was under the impression it was a hard rule as I was requested to change my user.name on my first contribution (#483 (comment)). If this is a remnant from node.js days, I'm all for dropping it.

@Fishrock123
Copy link
Contributor

@rvagg should this be reverted?

@aredridel
Copy link
Contributor

Please. Real names are slippery beasts and I really don't want to use the one that is still my legal name. There is no reason to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants