Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove common.PORT from client abort #12461

Closed
wants to merge 2 commits into from
Closed

tests: remove common.PORT from client abort #12461

wants to merge 2 commits into from

Conversation

z0al
Copy link
Contributor

@z0al z0al commented Apr 17, 2017 •
edited
Loading

Refs: #12376

Tests updated:

  • test/parallel/test-tls-client-abort.js
  • test/parallel/test-tls-client-abort2.js
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

@z0al
test: change common.PORT to '0' in test/parallel/test-tls-client-abort
60e396c 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.
@z0al
test: use '0' as port in test-tls-client-abort2
e6a9f58 
Remove common.PORT in test-tls-client-abort2 and replace it with '0' to
eliminate EADDRINUSE errors.

Refs: #12376
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 17, 2017
Trott
Trott approved these changes Apr 17, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott
Copy link
Member

Trott commented Apr 17, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7454/

@Trott Trott mentioned this pull request Apr 18, 2017
Closed
64 tasks
jasnell pushed a commit that referenced this pull request Apr 19, 2017
@z0al @jasnell
test: remove uses of common.PORT in test-tls-client tests
825d390 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 19, 2017

Landed in 825d390

@jasnell jasnell closed this Apr 19, 2017
@z0al z0al deleted the change-port-in-tls-tests branch April 19, 2017 18:04
@z0al
Copy link
Contributor Author

z0al commented Apr 19, 2017

@jasnell thank you

evanlucas pushed a commit that referenced this pull request Apr 25, 2017
@z0al @evanlucas
test: remove uses of common.PORT in test-tls-client tests
6bca9b5 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@evanlucas evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
@z0al @evanlucas
test: remove uses of common.PORT in test-tls-client tests
6dd6e2d 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
@z0al @evanlucas
test: remove uses of common.PORT in test-tls-client tests
ddc3528 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
gibfahn pushed a commit that referenced this pull request May 16, 2017
@z0al @gibfahn
test: remove uses of common.PORT in test-tls-client tests
9ea65bf 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@z0al @MylesBorins
test: remove uses of common.PORT in test-tls-client tests
b1d26d8 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@z0al @andrew749
test: remove uses of common.PORT in test-tls-client tests
ad702a8 
Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: nodejs/node#12461
Ref: nodejs/node#12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@z0al @Trott @jasnell @santigimeno @cjihrig @gibfahn @nodejs-github-bot