Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: don't error at startup when cwd doesn't exist #1194

Merged
merged 2 commits into from
Mar 19, 2015
Merged

src: don't error at startup when cwd doesn't exist #1194

merged 2 commits into from
Mar 19, 2015

Commits on Mar 19, 2015

  1. src: don't error at startup when cwd doesn't exist 

    The current working directory may not exist when iojs starts up.  Don't
treat that as an error because it's still possible to do many useful
things, like evaluating a command line script or starting a REPL.

This commit also fixes an age-old Windows bug where process.argv[0] was
not properly expanded, that's why the parallel/test-process-argv-0 test
gets an update as well.

Fixes: nodejs#1184
PR-URL: nodejs#1194
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    2c6f79c View commit details
    Browse the repository at this point in the history

  2. lib: don't error in repl when cwd doesn't exist 

    The current working directory may not exist when the REPL starts up.
Don't treat that as an error because it's still possible to do many
useful things.  This is like the previous commit but for the REPL.

Fixes: nodejs#1184
PR-URL: nodejs#1194
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed Mar 19, 2015
    Configuration menu
    Copy the full SHA
    2b2e48a View commit details
    Browse the repository at this point in the history