Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make tests pass when configured --without-ssl #11631

Closed
wants to merge 8 commits into from
Closed

test: make tests pass when configured --without-ssl #11631

wants to merge 8 commits into from

Commits on Mar 3, 2017

  1. test: add checkCrypto to tls-connect.js 

    Currently when node is build --without-ssl and the test are run, the
test that use the tls-connect fixture will throw an Error saying that
Node was not built with ssl support. The error is thrown when the tls
module is required causing the test that use it to fail unstead of being
skipped when there is no ssl support to test.

This commit calls checkCrypto before requiring the tls module so that an
error is not thrown and the test skipped instead.
    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    5d8519a View commit details
    Browse the repository at this point in the history

  2. test: make test-parallel pass witout-ssl 

    This commit enables the test-parallel target to pass when the build is
configured --without-ssl

To configure and run:

$ ./configure --without-ssl --debug && make -j8 test-parallel

The update to test/testspy/__init__.py is for
test-cluster-inspector-debug-port.js which passes '--inspect={PORT} flag
to the node process which causes the process to exit as the inspector is
not enabled when ssl is disabled. The suggested solution here is to
simply remove the flag when v8_enable_inspector is 0 and then have a
check in the test like the others test in this commit.
    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    f6a0027 View commit details
    Browse the repository at this point in the history

  3. test: make addons/openssl-binding pass without-ssl 

    Add checks to the compilation of this addon and also a check when the
test is run to see if ssl is enabled or not. If it is not enabled then
skip this test.
    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    c9c6c2b View commit details
    Browse the repository at this point in the history

  4. remove empty line added by mistake

    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    a7b0c2e View commit details
    Browse the repository at this point in the history

  5. remove checkCrypto function

    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    4084f4b View commit details
    Browse the repository at this point in the history

  6. correct comment that does not make sense

    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    f6d7cb0 View commit details
    Browse the repository at this point in the history

  7. move reading of v8_enable_inspector to tools/test.py

    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    b440006 View commit details
    Browse the repository at this point in the history

  8. remove function call when requiring tls-connect

    @danbev
    danbev committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    3addfd0 View commit details
    Browse the repository at this point in the history