Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add Unicode characters regression test #11423

Closed
wants to merge 1 commit into from
Closed

test: add Unicode characters regression test #11423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/internal/test/unicode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
'use strict';

// This module exists entirely for regression testing purposes.
// See `test/parallel/test-internal-unicode.js`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth putting unicode in the comment, it looks like some tools care about this.

Copy link
Contributor Author

@aqrln aqrln Feb 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't actually matter much if Unicode characters in comments are encoded properly in Node's binary, if that's what you are talking about, IMO, though they may be useful for debugging, as @Fishrock123 noted. It is quite easy to test Unicode in comments automatically, either exporting a function with a comment inside in this module and checking fn.toString() in the test, or checking the whole value of process.binding('natives')['internal/test/unicode'], but I'd like the status of #11371 and #11417 to become clear before doing this so that this part of the test won't become obsolete as soon as either of these lands (if any). Not to mention that I don't think it is necessary to test Unicode in comments specially at all: how are they different from any other parts of the source code?


module.exports = '✓';
1 change: 1 addition & 0 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
'lib/internal/readline.js',
'lib/internal/repl.js',
'lib/internal/socket_list.js',
'lib/internal/test/unicode.js',
'lib/internal/url.js',
'lib/internal/util.js',
'lib/internal/v8_prof_polyfill.js',
Expand Down
12 changes: 12 additions & 0 deletions test/parallel/test-internal-unicode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';
require('../common');

// Flags: --expose-internals
//
// This test ensures that UTF-8 characters can be used in core JavaScript
// libraries built into Node's binary.

const assert = require('assert');
const character = require('internal/test/unicode');

assert.strictEqual(character, '✓');