Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add vm module edge cases #11265

Closed
wants to merge 1 commit into from
Closed

Commits on Feb 10, 2017

  1. test: add vm module edge cases

    Add two, admittedly contrived, examples that test
    edge cases of the vm module.
    They demonstrate that the if statements `if (maybe_rv.IsEmpty())` and
    `if (maybe_prop_attr.IsNothing())` in the GetterCallback
    and the QueryCallback are observable.
    
    Both GetterCallback and QueryCallback
    explicitly check the global_proxy() if a property is
    not found on the sandbox. In these tests, the explicit check
    inside the callback yields different results than deferring the
    check until after the callback. The check is deferred, if the
    callbacks do not intercept, i.e., if args.GetReturnValue().Set() is
    not called.
    fhinkel committed Feb 10, 2017
    Configuration menu
    Copy the full SHA
    13f05fa View commit details
    Browse the repository at this point in the history