Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add --abort-on-timeout option to test.py #11086

Closed
wants to merge 1 commit into from
Closed

test: add --abort-on-timeout option to test.py #11086

wants to merge 1 commit into from

Commits on Feb 2, 2017

  1. test: add --abort-on-timeout option to test.py 

    Currently, when a process times out, it is terminated by sending it the
SIGTERM signal. Sending SIGBART instead allows the operating system to
generate a core file that can be investigated later using post-mortem
debuggers such as llnode or mdb_v8.

This can be very useful when investigating flaky tests that time out,
since in that case the failure is difficult to reproduce, and being able
to look at a core file makes a big difference.

With these changes, passing the --abort-on-timeout command line option
to tools/test.py now sends SIGABRT to processes timing out on all
platforms but Windows.

Refs: nodejs#11026
    Julien Gilli committed Feb 2, 2017
    Configuration menu
    Copy the full SHA
    b688f35 View commit details
    Browse the repository at this point in the history