test: increase coverage of dns-lookup #10844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
mscdex
added
dns
jasnell
approved these changes
Jan 17, 2017
lpinca
reviewed
Jan 17, 2017
| family: 0, | ||
| all: true | ||
| }, common.mustCall((error, result, addressType) => { | ||
| assert.strictEqual(error, null); |
hiroppy
force-pushed
the
feature/modify-test-dns-lookup
branch
from
24b1329
to
2963c2d
Compare
lpinca
approved these changes
Jan 17, 2017
cjihrig
reviewed
Jan 17, 2017
| const common = require('../common'); | ||
| const assert = require('assert'); | ||
| const cares = process.binding('cares_wrap'); | ||
|
|
There was a problem hiding this comment.
Could you remove this blank line.
cjihrig
approved these changes
Jan 17, 2017
Rename `test-dns-lookup-cb-error.js` to `test-dns-lookup.js`. lookup: https://github.com/nodejs/node/blob/master/lib/dns.js#L105. Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/dns.js.html
hiroppy
force-pushed
the
feature/modify-test-dns-lookup
branch
from
2963c2d
to
820f71a
Compare
italoacasas
approved these changes
Jan 17, 2017
|
Landed 48da656 |
italoacasas
pushed a commit
that referenced
this pull request
Jan 18, 2017
PR-URL: #10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
PR-URL: nodejs#10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
PR-URL: nodejs#10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
|
this would need a backport PR if it needs to land in v4 |
jasnell
pushed a commit
that referenced
this pull request
Mar 8, 2017
PR-URL: #10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #10844 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
test-dns-lookup-cb-error.jstotest-dns-lookup.js.lookup: https://github.com/nodejs/node/blob/master/lib/dns.js#L105.
Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/dns.js.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test