HTTP response getHeader doc fix #10817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
gibfahn
reviewed
Jan 15, 2017
| Reads out a header that's already been queued but not sent to the client. Note | ||
| that the name is case insensitive. This can only be called before headers get | ||
| implicitly flushed. | ||
| Reads out a header that's already been queued but not sent to the client. Note that the name is case insensitive |
There was a problem hiding this comment.
Could you keep the first two sentences wrapped to <80chars? The diff should look something like:
-that the name is case insensitive. This can only be called before headers get
-implicitly flushed.
+that the name is case insensitive.
|
cc/ @mscdex |
thefourtheye
approved these changes
Jan 15, 2017
thefourtheye
suggested changes
Jan 15, 2017
There was a problem hiding this comment.
Oh wait, the commit log should have subsystem. Please refer https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit
According to nodejs#10803 getHeader need not be called only before it is flushed implicitly.
jasnell
approved these changes
Jan 16, 2017
lpinca
approved these changes
Jan 17, 2017
|
LGTM |
thefourtheye
approved these changes
Jan 17, 2017
|
Landed in 90a2bb5 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
According to nodejs#10803 getHeader need not be called only before it is flushed implicitly. PR-URL: nodejs#10817 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
According to nodejs#10803 getHeader need not be called only before it is flushed implicitly. PR-URL: nodejs#10817 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
According to nodejs#10803 getHeader need not be called only before it is flushed implicitly. PR-URL: nodejs#10817 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
According to nodejs#10803 getHeader need not be called only before it is flushed implicitly. PR-URL: nodejs#10817 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #10803
getHeader need not be called only before it is flushed implicitly.
Affected core subsystem(s)
doc