Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix wrk check #1076

Closed
wants to merge 1 commit into from
Closed

benchmark: fix wrk check #1076

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Mar 5, 2015

Evidently .error is undefined if there was no error.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 5, 2015

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

mscdex added a commit to mscdex/io.js that referenced this pull request Mar 5, 2015
@mscdex
benchmark: fix wrk check
b27931b 
PR-URL: nodejs#1076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mscdex
Copy link
Contributor Author

mscdex commented Mar 5, 2015

Landed in b27931b.

@mscdex mscdex closed this Mar 5, 2015
@mscdex mscdex deleted the fix-benchmark-wrk-check branch March 5, 2015 22:14
@rvagg rvagg mentioned this pull request Mar 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mscdex @cjihrig @jbergstroem