Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport f795a79 from upstream V8 #10386

Closed
wants to merge 1 commit into from

Commits on Dec 21, 2016

  1. deps: backport f795a79 from upstream V8

    Original commit message:
        Rewrite scopes in computed properties in destructured parameters
    
        While we properly handled scopes of initializers in destructured
        parameters,
        we never did the right thing for computed properties. This patch
        fixes that
        by factoring out PatternRewriter's scope rewriting logic and calls
        it for the computed property case.
    
        BUG=chromium:620119
    
        Review-Url: https://codereview.chromium.org/2084103002
        Cr-Commit-Position: refs/heads/master@{nodejs#37228}
    
    Fixes: nodejs#10347
    targos committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    23de4e3 View commit details
    Browse the repository at this point in the history