Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: define missing operator delete functions #10356

Closed
wants to merge 2 commits into from
Closed

deps: define missing operator delete functions #10356

wants to merge 2 commits into from

Commits on Dec 20, 2016

  1. deps: define missing operator delete functions 

    Section 3.2 of the C++ standard states that destructor definitions
implicitly "use" operator delete functions. Therefore, these operator
delete functions must be defined even if they are never called by
user code explicitly.
http://www.open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#261

gcc allows them to remain as empty definitions. However, not all
compilers allow this.

This pull request creates definitions which if ever called, result
in an abort.
    @jBarz @bnoordhuis
    jBarz authored and bnoordhuis committed Dec 20, 2016
    Configuration menu
    Copy the full SHA
    f640fc8 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2016

  1. [squash] bump V8 patchlevel

    @addaleax
    addaleax committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    40f2262 View commit details
    Browse the repository at this point in the history