deps: update openssl to 1.0.1j #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rubber-stamp LGTM. It would be nice if the commit log explained why it fixes nodejs/node-v0.x-archive#8555. |
|
Erm, I guess I'd just remove the reference, as it is fixing only the comment in issue, not the issue itself. |
indutny
added a commit
that referenced
this pull request
Nov 27, 2014
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #1
|
Landed in 574407a, thank you! |
Closed
Closed
ghost
mentioned this pull request
Closed
sungpaks
added a commit
to sungpaks/node
that referenced
this pull request
Jul 29, 2024
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message "Can't read package.json" on non-existent file. However, the subtests failed on Ubuntu20.04. we found that attempting to run a non-existent script like `node --run foo` using the latest version of node results in an error message like `Can't find “scripts” field in package.json` (on Ubuntu20.04, regardless of whether package.json is present in the subpath or not). So we modified the subtest so that if we match either of the two messages, the test passes.
sungpaks
added a commit
to sungpaks/node
that referenced
this pull request
Jul 29, 2024
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message "Can't read package.json" on non-existent file. However, the subtests failed on Ubuntu20.04. we found that attempting to run a non-existent script like `node --run foo` using the latest version of node results in an error message like `Can't find “scripts” field in package.json` (on Ubuntu20.04, regardless of whether package.json is present in the subpath or not). So we modified the subtest so that if we match either of the two messages, the test passes.
giancorderoortiz
added a commit
to giancorderoortiz/node_backports
that referenced
this pull request
Sep 6, 2024
Original commit message:
Merged: [parser] Using FunctionParsingScope for parsing class static blocks
Class static blocks contain statements, don't inherit the
ExpressionScope stack.
(cherry picked from commit 3e037e195e508dea045f5626862412e8f64fc919)
Bug: 341663589
Change-Id: Ice9a710293b028e5d9fd30d5d85c4842f970b152
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5558360
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.4@{nodejs#38}
Cr-Branched-From: 309640da62fae0485c7e4f64829627c92d53b35d-refs/heads/12.4.254@{nodejs#1}
Cr-Branched-From: 5dc24701432278556a9829d27c532f974643e6df-refs/heads/main@{#92862}
Refs: v8/v8@6e5e105
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nodejs/node-v0.x-archive#8555