socket name of unix domain sockets #954
Labels
feature request
Issues that request new features to be added to Node.js.
help wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
libuv
Issues and PRs related to the libuv dependency or the uv binding.
net
Issues and PRs related to the net subsystem.
stalled
Issues and PRs that are stalled.
Comments
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this issue
Mar 21, 2015
The implementation is a minor API change in that socket.address() now
returns a `{ address: '/path/to/socket' }` object, like it does for TCP
and UDP sockets. Before this commit, it returned `socket._pipeName`,
which is a string when present.
Change common.PIPE on Windows from '\\\\.\\pipe\\libuv-test' to
'\\\\?\\pipe\\libuv-test'. Windows converts the '.' to a '?' when
creating a named pipe, meaning that common.PIPE didn't match the
result from NtQueryInformationFile().
Fixes: nodejs#954
|
Wow, until now I didn't know this issue was being worked on and solved. Great work and an example of how active this community is compared with joyent/node where this issue is still untouched. |
|
Should this be reopened because the patch hasn't landed yet? |
brendanashworth
added
the
feature request
|
Yeah I think so, sorry for prematurely closing this. PR is here: #956 |
|
No problem, the patch almost went in before it was deemed semver-major anyways. |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this issue
Aug 27, 2015
The implementation is a minor API change in that socket.address() now
returns a `{ address: '/path/to/socket' }` object, like it does for TCP
and UDP sockets. Before this commit, it returned `socket._pipeName`,
which is a string when present.
Change common.PIPE on Windows from '\\\\.\\pipe\\libuv-test' to
'\\\\?\\pipe\\libuv-test'. Windows converts the '.' to a '?' when
creating a named pipe, meaning that common.PIPE didn't match the
result from NtQueryInformationFile().
Fixes: nodejs#954
PR-URL: nodejs#956
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
Fixed by f337595. |
|
Reverted in de88255, reopening. |
Trott
added
stalled
|
Closing, see #12907 - the current behavior of returning a string has been documented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is currently impossible to get the path of a connected unix domain socket. socket.address() returns an empty object if it's not connected over AFINET.
I've looked at lib/net.js, src/tcp_wrap.cc, src/pipe_wrap.cc and libuv and it looks like libuv has support for returning the name of the socket and it is only pipe_wrap.cc that misses something like GetPeerName (I'm not a C coder so I might be wrong on this).
(also filed at nodejs/node-v0.x-archive#9120 a while ago)
The text was updated successfully, but these errors were encountered: