Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky sequential/test-net-GH-5504 on SmartOS #8930

Closed
Trott opened this issue Oct 4, 2016 · 1 comment
Closed

investigate flaky sequential/test-net-GH-5504 on SmartOS #8930

Trott opened this issue Oct 4, 2016 · 1 comment
Labels
net Issues and PRs related to the net subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Oct 4, 2016

https://ci.nodejs.org/job/node-test-commit-smartos/4589/nodes=smartos16-64/console:

not ok 1235 sequential/test-net-GH-5504
# SERVER 2>NET 17677: listen2 127.0.0.1 12346 4 false undefined
# SERVER 2>NET 17677: _listen2: create a handle
# SERVER 2>NET 17677: bind to 127.0.0.1
# CLIENT 2>NET 17678: createConnection [ { host: '127.0.0.1', port: 12346 }, [Function] ]
# CLIENT 2>NET 17678: pipe false undefined
# /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos16-64/test/sequential/test-net-GH-5504.js:55
#       throw new Error('hang');
#       ^
# 
# Error: hang
#     at Timeout._onTimeout (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos16-64/test/sequential/test-net-GH-5504.js:55:13)
#     at ontimeout (timers.js:365:14)
#     at tryOnTimeout (timers.js:237:5)
#     at Timer.listOnTimeout (timers.js:207:5)
# SERVER 1>listening
  ---
  duration_ms: 2.424

/cc @geek @misterdjules

Maybe /cc @bnoordhuis too as they provided the fix for the last bout of flakiness with this test (although that was on Windows)

@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Oct 4, 2016
@geek
Copy link
Member

geek commented Oct 5, 2016

@Trott I will take a look, this appeared in a test run for me as well: https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos16-64/4612/console

evanlucas pushed a commit that referenced this issue Nov 7, 2016
The test is failing on `SmartOS` quite often. Removing the timeout seems
to fix it.

Fixes: #8930
PR-URL: #9461
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this issue Nov 22, 2016
The test is failing on `SmartOS` quite often. Removing the timeout seems
to fix it.

Fixes: #8930
PR-URL: #9461
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net Issues and PRs related to the net subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

2 participants