Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing collaborators to README #778

Closed
3 tasks done
rvagg opened this issue Feb 10, 2015 · 6 comments
Closed
3 tasks done

Add missing collaborators to README #778

rvagg opened this issue Feb 10, 2015 · 6 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@rvagg
Copy link
Member

rvagg commented Feb 10, 2015

We're missing some new collaborators from the README, would the following people mind submitting a PR to get their details on there please?

It's a helpful part of the onboarding process for a couple of reasons:

  1. practice & a safe way to check that you're on the right wavelength re git workflow
  2. demonstrate that the project really is open
  3. provide additional kudos to those putting in the hard work here
@shigeki
Copy link
Contributor

shigeki commented Feb 10, 2015

@rvagg I don't mind submitting PR but I'd like to have a sample what to write or see what others write.

@vkurchatkin
Copy link
Contributor

@shigeki something like this 96597bc

@rvagg
Copy link
Member Author

rvagg commented Feb 10, 2015

git log -- README.md yields the interesting results and points towards recent PRs:

See the merged commits for the process of merging them once you get a "lgtm" or two. If you need any further help please reach out for help and people will jump to your rescue.

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Feb 10, 2015
@shigeki
Copy link
Contributor

shigeki commented Feb 10, 2015

@vkurchatkin @rvagg Thanks for advice. I thought I need to write some kind of vitae somewhere :-) It's a simple PR procedure. I will do it right now.

shigeki pushed a commit to shigeki/node that referenced this issue Feb 10, 2015
doc: add shigeki as collaborator
1d160fe 
Fixes: nodejs#778
@shigeki shigeki mentioned this issue Feb 10, 2015
Closed
shigeki pushed a commit that referenced this issue Feb 10, 2015
doc: add shigeki as collaborator
aea9b89 
Fixes: #778
PR-URL: #782

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@sam-github
Copy link
Contributor

Sorry, @rvagg @chrisdickinson I've been distracted by node summit!

@sam-github sam-github mentioned this issue Feb 11, 2015
Closed
@geek geek mentioned this issue Feb 13, 2015
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Feb 15, 2015

Looks like everyone mentioned here has been added.

@cjihrig cjihrig closed this as completed Feb 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sam-github @rvagg @shigeki @Fishrock123 @cjihrig @vkurchatkin