Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Undocumented NAPTR DNS record type #6507

Closed
MrQubo opened this issue May 1, 2016 · 1 comment
Closed

doc: Undocumented NAPTR DNS record type #6507

MrQubo opened this issue May 1, 2016 · 1 comment
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.

Comments

@MrQubo
Copy link

MrQubo commented May 1, 2016 •
edited by silverwind
Loading

The DNS documentation is missing resolveNaptr().
'NAPTR' should be added as valid value for rrtype below dns.resolve(hostname[, rrtype], callback).

DNS documentation: https://nodejs.org/dist/latest-v6.x/docs/api/dns.html
@mscdex mscdex added doc Issues and PRs related to the documentations. dns Issues and PRs related to the dns subsystem. labels May 1, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 2, 2016

Documentation PRs are welcome :-)

@silverwind silverwind added the good first issue Issues that are suitable for first-time contributors. label May 2, 2016
@doug-wade doug-wade mentioned this issue May 5, 2016
Closed
3 tasks
@Fishrock123 Fishrock123 removed the good first issue Issues that are suitable for first-time contributors. label May 5, 2016
Fishrock123 pushed a commit that referenced this issue May 23, 2016
@doug-wade @Fishrock123
doc: Add resolveNaptr and naptr rrtype docs
cb5ef10 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit that referenced this issue Jun 2, 2016
@doug-wade @rvagg
doc: Add resolveNaptr and naptr rrtype docs
0ae512a 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jul 11, 2016
@doug-wade
doc: Add resolveNaptr and naptr rrtype docs
e995546 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jul 11, 2016
@doug-wade
doc: Add resolveNaptr and naptr rrtype docs
6300f4d 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@doug-wade @MylesBorins
doc: Add resolveNaptr and naptr rrtype docs
4e86a88 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jul 12, 2016
@doug-wade
doc: Add resolveNaptr and naptr rrtype docs
5aaba2c 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@doug-wade
doc: Add resolveNaptr and naptr rrtype docs
e1944eb 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this issue Jul 14, 2016
@doug-wade
doc: Add resolveNaptr and naptr rrtype docs
7813af7 
Updates the dns module documentation to include documentation on
the resolveNaptr method, and also adds the option NAPTR to the
list of valid values for rrtype in dns.resolve(hostname[, rrtype],
callback).

PR-URL: #6586
Fixes: #6507
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@sam-github sam-github added doc Issues and PRs related to the documentations. and removed doc Issues and PRs related to the documentations. labels Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dns Issues and PRs related to the dns subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sam-github @mscdex @silverwind @jasnell @Fishrock123 @cjihrig @MrQubo