Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Scrollbar width #6443

Closed
mathiask88 opened this issue Apr 28, 2016 · 8 comments
Closed

Docs: Scrollbar width #6443

mathiask88 opened this issue Apr 28, 2016 · 8 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@mathiask88
Copy link
Contributor

  • Version: --
  • Platform: Chrome 50
  • Subsystem: DOCS

Would it be possible to set the scrollbar width to a reasonably value like 20px? I'm on a 3440x1440px device and it is so so hard to hit that tiny little bar :)

image

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 28, 2016

Even on 1366x768 they are hard to hit, both the TOC and the content scrollbars.

@ChALkeR
Copy link
Member

ChALkeR commented Apr 28, 2016

screenshot_20160428_131842

It looks like that to me. It's fine, but could be a bit wider though.

Would it be possible to set the scrollbar width to a reasonably value like 20px? I'm on a 3440x1440px

Note that device pixels and (css) reference pixels are not the same. Reference pixel is defined though visual angle.

So, this should not depend on the devices resolution, but instead the actual question is — is 10 reference pixels scrollbar too small?

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Apr 28, 2016
@mathiask88
Copy link
Contributor Author

mathiask88 commented Apr 28, 2016

@ChALkeR Yes but it is PPI dependend. My Monitor got 190PPI and the scrollbar is really tricky to click. Often I even cant see the grey bar on the white background :)

@ChALkeR
Copy link
Member

ChALkeR commented Apr 28, 2016

@mathiask88 This looks like your machine is misconfigured, then. The visual angle of one css pixel isn't PPI dependent (except for rounding error). It's the visual angle and the PPI that define the device pixel ratio that should be set on your system for everything to be rendered correctly.

@mathiask88
Copy link
Contributor Author

@ChALkeR Thanks, I learned something new :) Nevertheless for me personally it is definitely too small :/

@claudiorodriguez
Copy link
Contributor

I'll whip up a quick PR with a media query or two. Would you consider 20px to be reasonable for widths 2048 and higher? I don't have a big enough monitor on me at the moment.

@ChALkeR
Copy link
Member

ChALkeR commented Apr 28, 2016

@mathiask88 CSS pixels were the same as device pixels when the latest Firefox version was 3.6 (don't confuse with 36).

Reference: https://www.w3.org/TR/css3-values/#absolute-lengths

The reference pixel is the visual angle of one pixel on a device with a pixel density of 96dpi and a distance from the reader of an arm’s length. For a nominal arm’s length of 28 inches, the visual angle is therefore about 0.0213 degrees. For reading at arm’s length, 1px thus corresponds to about 0.26 mm (1/96 inch).

For example, for PPI = 380 the scrollbars shouldn't be smaller than for PPI = 96, they would be more accurately drawn, because the device pixel ratio would be equal to 4 (for a device at the distance of an arm's length, e.g. a monitor).

@mathiask88
Copy link
Contributor Author

@ChALkeR Ok got it. But I like the default 96dpi setting in windows on my 190PPI device so as a result i got a device pixel ratio of 1. And because I am also about 1 arm lenght away from my monitor the bars are only half the size of e.g your device. If i compare your screenshot with mine i need a zoom of ~200% for the same size (device pixel ratio is then 2) So I would like to stay at 96 dpi scaling in windows and be able to click that scroll bars :) It would also be okay if the bar in the content frame would be non custom because the size of the default browser bars are okay.

claudiorodriguez added a commit to claudiorodriguez/node that referenced this issue Apr 28, 2016
Adds media queries to doc css to make TOC and content scrollbars
wider in larger screens.

Fixes: nodejs#6443
PR-URL: nodejs#6445
claudiorodriguez added a commit to claudiorodriguez/node that referenced this issue Apr 29, 2016
Returns the scrollbar to native style.

Fixes: nodejs#6443
Fishrock123 pushed a commit that referenced this issue May 4, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this issue May 4, 2016
Returns the doc custom scrollbar to native style.

Fixes: nodejs#6443
PR-URL: nodejs#6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 1, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this issue Jun 24, 2016
Returns the doc custom scrollbar to native style.

Fixes: #6443
PR-URL: #6479
Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
4 participants