-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/parallel/test-release-changelog.js is failing on the main branch #50373
Comments
I'm not able to fix it myself today so anyone feel free to do it, but why didn't it fail in the release proposal pull request? |
We need to update node_version.h on the main branch |
I think we're missing a step for semver majors. We need to bump the major version on |
I see you've figured it out. For everyone else, #50375 (comment) explains why. |
- Fix the version for main branch as 22.0.0 - Fix the NODE_VERSION_IS_RELEASE flag for the main branch This would allow test/parallel/test-release-changelog.js to pass again on the main branch. PR-URL: #50375 Fixes: #50373 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
- Fix the version for main branch as 22.0.0 - Fix the NODE_VERSION_IS_RELEASE flag for the main branch This would allow test/parallel/test-release-changelog.js to pass again on the main branch. PR-URL: nodejs#50375 Fixes: nodejs#50373 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
See error
The text was updated successfully, but these errors were encountered: