Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/parallel/test-release-changelog.js is failing on the main branch #50373

Closed
joyeecheung opened this issue Oct 24, 2023 · 4 comments · Fixed by #50375
Closed

test/parallel/test-release-changelog.js is failing on the main branch #50373

joyeecheung opened this issue Oct 24, 2023 · 4 comments · Fixed by #50375

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Oct 24, 2023 •
edited
Loading

See error 
node:assert:1026
    throw err;
    ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /<b><a href="doc\/changelogs\/CHANGELOG_V21.md#21\.0\.0">21\.0\.0<\/a><\/b><br\/>/. Input:

'# Node.js Changelog\n' +
  '\n' +
  'Select a Node.js version below to view the changelog history:\n' +
  '\n' +
  '* [Node.js 21](doc/changelogs/CHANGELOG_V21.md) **Current**\n' +
  '* [Node.js 20](doc/changelogs/CHANGELOG_V20.md) **Long Term Support**\n' +
  '* [Node.js 19](doc/changelogs/CHANGELOG_V19.md) End-of-Life\n' +
  '* [Node.js 18](doc/changelogs/CHANGELOG_V18.md) **Long Term Support**\n' +
  '* [Node.js 17](doc/changelogs/CHANGELOG_V17.md) End-of-Life\n' +
  '* [Node.js 16](doc/changelogs/CHANGELOG_V16.md) End-of-Life\n' +
  '* [Node.js 15](doc/changelogs/CHANGELOG_V15.md) End-of-Life\n' +
  '* [Node.js 14](doc/changelogs/CHANGELOG_V14.md) End-of-Life\n' +
  '* [Node.js 13](doc/changelogs/CHANGELOG_V13.md) End-of-Life\n' +
  '* [Node.js 12](doc/changelogs/CHANGELOG_V12.md) End-of-Life\n' +
  '* [Node.js 11](doc/changelogs/CHANGELOG_V11.md) End-of-Life\n' +
  '* [Node.js 10](doc/changelogs/CHANGELOG_V10.md) End-of-Life\n' +
  '* [Node.js 9](doc/changelogs/CHANGELOG_V9.md) End-of-Life\n' +
  '* [Node.js 8](doc/changelogs/CHANGELOG_V8.md) End-of-Life\n' +
  '* [Node.js 7](doc/changelogs/CHANGELOG_V7.md) End-of-Life\n' +
  '* [Node.js 6](doc/changelogs/CHANGELOG_V6.md) End-of-Life\n' +
  '* [Node.js 5](doc/changelogs/CHANGELOG_V5.md) End-of-Life\n' +
  '* [Node.js 4](doc/changelogs/CHANGELOG_V4.md) End-of-Life\n' +
  '* [io.js](doc/changelogs/CHANGELOG_IOJS.md) End-of-Life\n' +
  '* [Node.js 0.12](doc/changelogs/CHANGELOG_V012.md) End-of-Life\n' +
  '* [Node.js 0.10](doc/changelogs/CHANGELOG_V010.md) End-of-Life\n' +
  '* [Archive](doc/changelogs/CHANGELOG_ARCHIVE.md)\n' +
  '\n' +
  'Please use the following table to find the changelog for a specific Node.js\n' +
  'release.\n' +
  '\n' +
  '<table>\n' +
  '<tr>\n' +
  '  <th title="Current"><a href="doc/changelogs/CHANGELOG_V21.md">21</a> (Current)</th>\n' +
  '  <th title="LTS Until 2026-04"><a href="doc/changelogs/CHANGELOG_V20.md">20</a> (LTS)</th>\n' +
  '  <th title="LTS Until 2025-04"><a href="doc/changelogs/CHANGELOG_V18.md">18</a> (LTS)</th>\n' +
  '</tr>\n' +
  '<tr>\n' +
  '  <td valign="top">\n' +
  '<b><a href="doc/changelogs/CHANGELOG_V21.md#21.1.0">21.1.0</a></b><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V21.md#21.0.0">21.0.0</a><br/>\n' +
  '  </td>\n' +
  '  <td valign="top">\n' +
  '<b><a href="doc/changelogs/CHANGELOG_V20.md#20.9.0">20.9.0</a></b><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.8.1">20.8.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.8.0">20.8.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.7.0">20.7.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.6.1">20.6.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.6.0">20.6.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.5.1">20.5.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.5.0">20.5.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.4.0">20.4.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.3.1">20.3.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.3.0">20.3.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.2.0">20.2.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.1.0">20.1.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V20.md#20.0.0">20.0.0</a><br/>\n' +
  '  </td>\n' +
  '  <td valign="top">\n' +
  '<b><a href="doc/changelogs/CHANGELOG_V18.md#18.18.2">18.18.2</a></b><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.18.1">18.18.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.18.0">18.18.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.17.1">18.17.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.17.0">18.17.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.16.1">18.16.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.16.0">18.16.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.15.0">18.15.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.14.2">18.14.2</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.14.1">18.14.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.14.0">18.14.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.13.0">18.13.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.12.1">18.12.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.12.0">18.12.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.11.0">18.11.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.10.0">18.10.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.9.1">18.9.1</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.9.0">18.9.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.8.0">18.8.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.7.0">18.7.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.6.0">18.6.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.5.0">18.5.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.4.0">18.4.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.3.0">18.3.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.2.0">18.2.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.1.0">18.1.0</a><br/>\n' +
  '<a href="doc/changelogs/CHANGELOG_V18.md#18.0.0">18.0.0</a><br/>\n' +
  '  </td>\n' +
  '</tr>\n' +
  '</table>\n' +
  '\n' +
  '## Notes\n' +
  '\n' +
  '* The [Node.js Long Term Support plan](https://github.com/nodejs/Release) covers\n' +
  '  LTS releases.\n' +
  '* Release versions in **bold** text are the most recent supported releases.\n' +
  '\n' +
  '***\n' +
  '\n' +
  '***\n' +
  '\n' +
  '## 2016-05-06, Version 0.12.14 (Maintenance), @rvagg\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.14">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.14</a>.\n' +
  '\n' +
  '## 2016-05-06, Version 0.10.45 (Maintenance), @rvagg\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V010.md#0.10.45">Moved to doc/changelogs/CHANGELOG\\_V010.md#0.10.45</a>.\n' +
  '\n' +
  '## 2016-05-05, Version 6.1.0 (Current), @Fishrock123\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V6.md#6.1.0">Moved to doc/changelogs/CHANGELOG\\_V6.md#6.1.0</a>.\n' +
  '\n' +
  '## 2016-05-05, Version 5.11.1 (Stable), @evanlucas\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.11.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.11.1</a>.\n' +
  '\n' +
  "## 2016-05-05, Version 4.4.4 'Argon' (LTS), @thealphanerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.4">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.4</a>.\n' +
  '\n' +
  '## 2016-04-26, Version 6.0.0 (Current), @jasnell\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V6.md#6.0.0">Moved to doc/changelogs/CHANGELOG\\_V6.md#6.0.0</a>.\n' +
  '\n' +
  '## 2016-04-20, Version 5.11.0 (Stable), @thealphanerd\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.11.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.11.0</a>.\n' +
  '\n' +
  '## 2016-04-05, Version 5.10.1 (Stable), @thealphanerd\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.10.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.10.1</a>.\n' +
  '\n' +
  '## 2016-03-31, Version 0.10.44 (Maintenance), @rvagg\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V010.md#0.10.44">Moved to doc/changelogs/CHANGELOG\\_V010.md#0.10.44</a>.\n' +
  '\n' +
  '## 2016-03-31, Version 5.10.0 (Stable), @evanlucas\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.10.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.10.0</a>.\n' +
  '\n' +
  "## 2016-03-31, Version 4.4.2 'Argon' (LTS), @thealphanerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.2">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.2</a>.\n' +
  '\n' +
  '## 2016-03-31, Version 0.12.13 (LTS), @rvagg\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.13">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.13</a>.\n' +
  '\n' +
  '## 2016-03-23, Version 5.9.1 (Stable), @Fishrock123\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.9.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.9.1</a>.\n' +
  '\n' +
  "## 2016-03-22, Version 4.4.1 'Argon' (LTS), @thealphanerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.1">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.1</a>.\n' +
  '\n' +
  '## 2016-03-16, Version 5.9.0 (Stable), @evanlucas\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.9.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.9.0</a>.\n' +
  '\n' +
  '## 2016-03-08, Version 5.8.0 (Stable), @Fishrock123\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.8.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.8.0</a>.\n' +
  '\n' +
  "## 2016-03-08, Version 4.4.0 'Argon' (LTS), @thealphanerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.0">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.0</a>.\n' +
  '\n' +
  '## 2016-03-08, Version 0.12.12 (LTS), @rvagg\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.12">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.12</a>.\n' +
  '\n' +
  '## 2016-03-03, Version 0.12.11 (LTS), @rvagg\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.11">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.11</a>.\n' +
  '\n' +
  '## 2016-03-02, Version 5.7.1 (Stable), @Fishrock123\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.7.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.7.1</a>.\n' +
  '\n' +
  "## 2016-03-02, Version 4.3.2 'Argon' (LTS), @thealphanerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.3.2">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.3.2</a>.\n' +
  '\n' +
  '## 2016-02-23, Version 5.7.0 (Stable), @rvagg\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.7.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.7.0</a>.\n' +
  '\n' +
  "## 2016-02-16, Version 4.3.1 'Argon' (LTS), @thealphanerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.3.1">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.3.1</a>.\n' +
  '\n' +
  '## 2016-02-09, Version 5.6.0 (Stable), @jasnell\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.6.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.6.0</a>.\n' +
  '\n' +
  "## 2016-02-09, Version 4.3.0 'Argon' (LTS), @jasnell\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.3.0">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.3.0</a>.\n' +
  '\n' +
  '## 2016-02-09, Version 0.12.10 (LTS), @jasnell\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.10">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.10</a>.\n' +
  '\n' +
  '## 2016-02-09, Version 0.10.42 (Maintenance), @jasnell\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V010.md#0.10.42">Moved to doc/changelogs/CHANGELOG\\_V010.md#0.10.42</a>.\n' +
  '\n' +
  "## 2016-01-21, Version 4.2.6 'Argon' (LTS), @TheAlphaNerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.2.6">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.2.6</a>.\n' +
  '\n' +
  '## 2016-01-20, Version 5.5.0 (Stable), @evanlucas\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.5.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.5.0</a>.\n' +
  '\n' +
  "## 2016-01-20, Version 4.2.5 'Argon' (LTS), @TheAlphaNerd\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4.md#4.2.5">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.2.5</a>.\n' +
  '\n' +
  '## 2016-01-12, Version 5.4.1 (Stable), @TheAlphaNerd\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.4.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.4.1</a>.\n' +
  '\n' +
  '## 2016-01-06, Version 5.4.0 (Stable), @Fishrock123\n' +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V5.md#5.4.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.4.0</a>.\n' +
  '\n' +
  "## 2015-12-23, Version 4.2.4 'Argon' (LTS), @jasnell\n" +
  '\n' +
  '<a href="doc/changelogs/CHANGELOG_V4'... 41508 more characters

    at Object.<anonymous> (/Users/joyee/projects/node/test/parallel/test-release-changelog.js:88:10)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '# Node.js Changelog\n' +
    '\n' +
    'Select a Node.js version below to view the changelog history:\n' +
    '\n' +
    '* [Node.js 21](doc/changelogs/CHANGELOG_V21.md) **Current**\n' +
    '* [Node.js 20](doc/changelogs/CHANGELOG_V20.md) **Long Term Support**\n' +
    '* [Node.js 19](doc/changelogs/CHANGELOG_V19.md) End-of-Life\n' +
    '* [Node.js 18](doc/changelogs/CHANGELOG_V18.md) **Long Term Support**\n' +
    '* [Node.js 17](doc/changelogs/CHANGELOG_V17.md) End-of-Life\n' +
    '* [Node.js 16](doc/changelogs/CHANGELOG_V16.md) End-of-Life\n' +
    '* [Node.js 15](doc/changelogs/CHANGELOG_V15.md) End-of-Life\n' +
    '* [Node.js 14](doc/changelogs/CHANGELOG_V14.md) End-of-Life\n' +
    '* [Node.js 13](doc/changelogs/CHANGELOG_V13.md) End-of-Life\n' +
    '* [Node.js 12](doc/changelogs/CHANGELOG_V12.md) End-of-Life\n' +
    '* [Node.js 11](doc/changelogs/CHANGELOG_V11.md) End-of-Life\n' +
    '* [Node.js 10](doc/changelogs/CHANGELOG_V10.md) End-of-Life\n' +
    '* [Node.js 9](doc/changelogs/CHANGELOG_V9.md) End-of-Life\n' +
    '* [Node.js 8](doc/changelogs/CHANGELOG_V8.md) End-of-Life\n' +
    '* [Node.js 7](doc/changelogs/CHANGELOG_V7.md) End-of-Life\n' +
    '* [Node.js 6](doc/changelogs/CHANGELOG_V6.md) End-of-Life\n' +
    '* [Node.js 5](doc/changelogs/CHANGELOG_V5.md) End-of-Life\n' +
    '* [Node.js 4](doc/changelogs/CHANGELOG_V4.md) End-of-Life\n' +
    '* [io.js](doc/changelogs/CHANGELOG_IOJS.md) End-of-Life\n' +
    '* [Node.js 0.12](doc/changelogs/CHANGELOG_V012.md) End-of-Life\n' +
    '* [Node.js 0.10](doc/changelogs/CHANGELOG_V010.md) End-of-Life\n' +
    '* [Archive](doc/changelogs/CHANGELOG_ARCHIVE.md)\n' +
    '\n' +
    'Please use the following table to find the changelog for a specific Node.js\n' +
    'release.\n' +
    '\n' +
    '<table>\n' +
    '<tr>\n' +
    '  <th title="Current"><a href="doc/changelogs/CHANGELOG_V21.md">21</a> (Current)</th>\n' +
    '  <th title="LTS Until 2026-04"><a href="doc/changelogs/CHANGELOG_V20.md">20</a> (LTS)</th>\n' +
    '  <th title="LTS Until 2025-04"><a href="doc/changelogs/CHANGELOG_V18.md">18</a> (LTS)</th>\n' +
    '</tr>\n' +
    '<tr>\n' +
    '  <td valign="top">\n' +
    '<b><a href="doc/changelogs/CHANGELOG_V21.md#21.1.0">21.1.0</a></b><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V21.md#21.0.0">21.0.0</a><br/>\n' +
    '  </td>\n' +
    '  <td valign="top">\n' +
    '<b><a href="doc/changelogs/CHANGELOG_V20.md#20.9.0">20.9.0</a></b><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.8.1">20.8.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.8.0">20.8.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.7.0">20.7.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.6.1">20.6.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.6.0">20.6.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.5.1">20.5.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.5.0">20.5.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.4.0">20.4.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.3.1">20.3.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.3.0">20.3.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.2.0">20.2.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.1.0">20.1.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V20.md#20.0.0">20.0.0</a><br/>\n' +
    '  </td>\n' +
    '  <td valign="top">\n' +
    '<b><a href="doc/changelogs/CHANGELOG_V18.md#18.18.2">18.18.2</a></b><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.18.1">18.18.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.18.0">18.18.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.17.1">18.17.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.17.0">18.17.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.16.1">18.16.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.16.0">18.16.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.15.0">18.15.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.14.2">18.14.2</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.14.1">18.14.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.14.0">18.14.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.13.0">18.13.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.12.1">18.12.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.12.0">18.12.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.11.0">18.11.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.10.0">18.10.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.9.1">18.9.1</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.9.0">18.9.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.8.0">18.8.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.7.0">18.7.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.6.0">18.6.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.5.0">18.5.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.4.0">18.4.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.3.0">18.3.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.2.0">18.2.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.1.0">18.1.0</a><br/>\n' +
    '<a href="doc/changelogs/CHANGELOG_V18.md#18.0.0">18.0.0</a><br/>\n' +
    '  </td>\n' +
    '</tr>\n' +
    '</table>\n' +
    '\n' +
    '## Notes\n' +
    '\n' +
    '* The [Node.js Long Term Support plan](https://github.com/nodejs/Release) covers\n' +
    '  LTS releases.\n' +
    '* Release versions in **bold** text are the most recent supported releases.\n' +
    '\n' +
    '***\n' +
    '\n' +
    '***\n' +
    '\n' +
    '## 2016-05-06, Version 0.12.14 (Maintenance), @rvagg\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.14">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.14</a>.\n' +
    '\n' +
    '## 2016-05-06, Version 0.10.45 (Maintenance), @rvagg\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V010.md#0.10.45">Moved to doc/changelogs/CHANGELOG\\_V010.md#0.10.45</a>.\n' +
    '\n' +
    '## 2016-05-05, Version 6.1.0 (Current), @Fishrock123\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V6.md#6.1.0">Moved to doc/changelogs/CHANGELOG\\_V6.md#6.1.0</a>.\n' +
    '\n' +
    '## 2016-05-05, Version 5.11.1 (Stable), @evanlucas\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.11.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.11.1</a>.\n' +
    '\n' +
    "## 2016-05-05, Version 4.4.4 'Argon' (LTS), @thealphanerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.4">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.4</a>.\n' +
    '\n' +
    '## 2016-04-26, Version 6.0.0 (Current), @jasnell\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V6.md#6.0.0">Moved to doc/changelogs/CHANGELOG\\_V6.md#6.0.0</a>.\n' +
    '\n' +
    '## 2016-04-20, Version 5.11.0 (Stable), @thealphanerd\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.11.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.11.0</a>.\n' +
    '\n' +
    '## 2016-04-05, Version 5.10.1 (Stable), @thealphanerd\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.10.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.10.1</a>.\n' +
    '\n' +
    '## 2016-03-31, Version 0.10.44 (Maintenance), @rvagg\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V010.md#0.10.44">Moved to doc/changelogs/CHANGELOG\\_V010.md#0.10.44</a>.\n' +
    '\n' +
    '## 2016-03-31, Version 5.10.0 (Stable), @evanlucas\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.10.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.10.0</a>.\n' +
    '\n' +
    "## 2016-03-31, Version 4.4.2 'Argon' (LTS), @thealphanerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.2">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.2</a>.\n' +
    '\n' +
    '## 2016-03-31, Version 0.12.13 (LTS), @rvagg\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.13">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.13</a>.\n' +
    '\n' +
    '## 2016-03-23, Version 5.9.1 (Stable), @Fishrock123\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.9.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.9.1</a>.\n' +
    '\n' +
    "## 2016-03-22, Version 4.4.1 'Argon' (LTS), @thealphanerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.1">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.1</a>.\n' +
    '\n' +
    '## 2016-03-16, Version 5.9.0 (Stable), @evanlucas\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.9.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.9.0</a>.\n' +
    '\n' +
    '## 2016-03-08, Version 5.8.0 (Stable), @Fishrock123\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.8.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.8.0</a>.\n' +
    '\n' +
    "## 2016-03-08, Version 4.4.0 'Argon' (LTS), @thealphanerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.4.0">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.4.0</a>.\n' +
    '\n' +
    '## 2016-03-08, Version 0.12.12 (LTS), @rvagg\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.12">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.12</a>.\n' +
    '\n' +
    '## 2016-03-03, Version 0.12.11 (LTS), @rvagg\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.11">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.11</a>.\n' +
    '\n' +
    '## 2016-03-02, Version 5.7.1 (Stable), @Fishrock123\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.7.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.7.1</a>.\n' +
    '\n' +
    "## 2016-03-02, Version 4.3.2 'Argon' (LTS), @thealphanerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.3.2">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.3.2</a>.\n' +
    '\n' +
    '## 2016-02-23, Version 5.7.0 (Stable), @rvagg\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.7.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.7.0</a>.\n' +
    '\n' +
    "## 2016-02-16, Version 4.3.1 'Argon' (LTS), @thealphanerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.3.1">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.3.1</a>.\n' +
    '\n' +
    '## 2016-02-09, Version 5.6.0 (Stable), @jasnell\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.6.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.6.0</a>.\n' +
    '\n' +
    "## 2016-02-09, Version 4.3.0 'Argon' (LTS), @jasnell\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.3.0">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.3.0</a>.\n' +
    '\n' +
    '## 2016-02-09, Version 0.12.10 (LTS), @jasnell\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V012.md#0.12.10">Moved to doc/changelogs/CHANGELOG\\_V012.md#0.12.10</a>.\n' +
    '\n' +
    '## 2016-02-09, Version 0.10.42 (Maintenance), @jasnell\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V010.md#0.10.42">Moved to doc/changelogs/CHANGELOG\\_V010.md#0.10.42</a>.\n' +
    '\n' +
    "## 2016-01-21, Version 4.2.6 'Argon' (LTS), @TheAlphaNerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.2.6">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.2.6</a>.\n' +
    '\n' +
    '## 2016-01-20, Version 5.5.0 (Stable), @evanlucas\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.5.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.5.0</a>.\n' +
    '\n' +
    "## 2016-01-20, Version 4.2.5 'Argon' (LTS), @TheAlphaNerd\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4.md#4.2.5">Moved to doc/changelogs/CHANGELOG\\_V4.md#4.2.5</a>.\n' +
    '\n' +
    '## 2016-01-12, Version 5.4.1 (Stable), @TheAlphaNerd\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.4.1">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.4.1</a>.\n' +
    '\n' +
    '## 2016-01-06, Version 5.4.0 (Stable), @Fishrock123\n' +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V5.md#5.4.0">Moved to doc/changelogs/CHANGELOG\\_V5.md#5.4.0</a>.\n' +
    '\n' +
    "## 2015-12-23, Version 4.2.4 'Argon' (LTS), @jasnell\n" +
    '\n' +
    '<a href="doc/changelogs/CHANGELOG_V4'... 41508 more characters,
  expected: /<b><a href="doc\/changelogs\/CHANGELOG_V21.md#21\.0\.0">21\.0\.0<\/a><\/b><br\/>/,
  operator: 'match'
}

Node.js v21.0.0
@targos
Copy link
Member

targos commented Oct 24, 2023

I'm not able to fix it myself today so anyone feel free to do it, but why didn't it fail in the release proposal pull request?
#50335

@joyeecheung
Copy link
Member Author

We need to update node_version.h on the main branch

@joyeecheung joyeecheung mentioned this issue Oct 24, 2023
Merged
@richardlau
Copy link
Member

I think we're missing a step for semver majors. We need to bump the major version on main.

@richardlau
Copy link
Member

I'm not able to fix it myself today so anyone feel free to do it, but why didn't it fail in the release proposal pull request? #50335

I see you've figured it out. For everyone else, #50375 (comment) explains why.

This was referenced Oct 24, 2023
Closed
Merged
nodejs-github-bot pushed a commit that referenced this issue Oct 24, 2023
@joyeecheung
src: fix node_version.h
89a26b4 
- Fix the version for main branch as 22.0.0
- Fix the NODE_VERSION_IS_RELEASE flag for the main branch

This would allow test/parallel/test-release-changelog.js
to pass again on the main branch.

PR-URL: #50375
Fixes: #50373
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@joyeecheung @alexfernandez
src: fix node_version.h
eb196fd 
- Fix the version for main branch as 22.0.0
- Fix the NODE_VERSION_IS_RELEASE flag for the main branch

This would allow test/parallel/test-release-changelog.js
to pass again on the main branch.

PR-URL: nodejs#50375
Fixes: nodejs#50373
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: fix node_version.h joyeecheung/node
3 participants
@targos @joyeecheung @richardlau