Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU 65.1 #29540

Closed
srl295 opened this issue Sep 12, 2019 · 11 comments
Closed

ICU 65.1 #29540

srl295 opened this issue Sep 12, 2019 · 11 comments
Assignees
@ryzokuken
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Sep 12, 2019

Followon to #26388 (64.2) et al.

RC at: http://site.icu-project.org/download/65

  • CLDR 36 (32k data items added)

Depends on #29523 (merged)

Is your feature request related to a problem? Please describe.
Describe the solution you'd like
Updated i18n Unicode, Timezone, Locale data support.
@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Sep 12, 2019
@srl295 srl295 self-assigned this Sep 12, 2019
@srl295 srl295 mentioned this issue Sep 27, 2019
Closed
@srl295
Copy link
Member Author

srl295 commented Oct 4, 2019

ICU 65.1 is GA yesterday-ish, http://site.icu-project.org/download/65

@ryzokuken would you like to do the honors here?

Note that with #29522 merged, the data change is a .bz2 file.

@ryzokuken
Copy link
Contributor

@srl295 totally! I'd take a stab at this over the weekend.

@ryzokuken ryzokuken assigned ryzokuken and unassigned srl295 Oct 5, 2019
@ryzokuken
Copy link
Contributor

Assigned myself for transparency :)

@srl295
Copy link
Member Author

srl295 commented Oct 7, 2019 via email

@ryzokuken
Copy link
Contributor

@srl295 I seem to have lost the notes from the last time you walked me through the upgrade 😅

If you have some free time today, would you like to do it again or point me to a resource? I'm planning not to change note-taking systems anytime soon so hopefully it'll be better next time :)

@srl295
Copy link
Member Author

srl295 commented Oct 10, 2019 via email

@ryzokuken
Copy link
Contributor

@srl295 I'll try my best to do it without asking for too much help.

@guilhermebr
Copy link

hi @ryzokuken, are you still working on this?

@ryzokuken
Copy link
Contributor

@guilhermebr really sorry that it took a while, my exams would be over tomorrow and hopefully you'll see a PR for this :)

@targos targos mentioned this issue Nov 1, 2019
Closed
@albertyw albertyw mentioned this issue Nov 3, 2019
Closed
4 tasks
@richardlau richardlau mentioned this issue Nov 3, 2019
Closed
@felipekm
Copy link

felipekm commented Nov 7, 2019

Looking forward for this implementation

@srl295 srl295 mentioned this issue Nov 12, 2019
Closed
4 tasks
albertyw added a commit to albertyw/node-1 that referenced this issue Nov 22, 2019
@albertyw
tools: update icu to 65.1
15ffd05 
Update the version of the bundled ICU (deps/icu-small) to ICU version
65.2.

Fixes: nodejs#30211
Fixes: nodejs#29540
@srl295
Copy link
Member Author

srl295 commented Dec 6, 2019 •
edited
Loading

^ just in time for the ICU4C 66preview announcement ! http://site.icu-project.org/download/66

edit and yes, Node.js passes tests fine with ICU4C 66preview. (Node.js will probably skip 66 and go to 67, but it will depend on timing)

targos pushed a commit that referenced this issue Dec 9, 2019
@albertyw @targos
tools: update icu to 65.1
0cb7720 
Update the version of the bundled ICU (deps/icu-small) to ICU version
65.2.

Fixes: #30211
Fixes: #29540

PR-URL: #30232
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
@jameshilliard jameshilliard mentioned this issue Jan 21, 2020
Closed
albertyw added a commit to albertyw/node-1 that referenced this issue Jan 21, 2020
@albertyw
tools: update icu to 65.1
2becb95 
Update the version of the bundled ICU (deps/icu-small) to ICU version
65.2.

Fixes: nodejs#30211
Fixes: nodejs#29540
Backport-PR-URL: nodejs#31434
PR-URL: nodejs#30356
PR-URL: nodejs#30232
jameshilliard pushed a commit to jameshilliard/node that referenced this issue Feb 17, 2020
@albertyw @jameshilliard
tools: update icu to 65.1
8e9e7d7 
Update the version of the bundled ICU (deps/icu-small) to ICU version
65.2.

Fixes: nodejs#30211
Fixes: nodejs#29540

PR-URL: nodejs#30232
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 1, 2020
@albertyw @MylesBorins
tools: update icu to 65.1
dca3d29 
Update the version of the bundled ICU (deps/icu-small) to ICU version
65.2.

Fixes: #30211
Fixes: #29540

Backport-PR-URL: #31433
PR-URL: #30232
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryzokuken ryzokuken

Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: Update icu to 65.1 albertyw/node-1
4 participants
@felipekm @guilhermebr @srl295 @ryzokuken