Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: deprecate/rename finished in favour of ended #28651

Closed
ronag opened this issue Jul 12, 2019 · 4 comments
Closed

http: deprecate/rename finished in favour of ended #28651

ronag opened this issue Jul 12, 2019 · 4 comments

Comments

@ronag
Copy link
Member

ronag commented Jul 12, 2019

What is currently the finished property in http/1 is actually what is ended in the world of streams.

Would it be an idea to deprecate finished (e.g. remove from docs and/or add warning) and add an alias/property called ended instead to better match the streams spec and avoid confusion?
@ronag ronag changed the title http: deprecate finished in favour of ended alias http: deprecate/rename finished in favour of ended Jul 12, 2019
@Trott
Copy link
Member

Trott commented Jul 13, 2019

@nodejs/http @nodejs/streams

@mcollina
Copy link
Member

I'm in favor of a doc-deprecation.

@ronag
Copy link
Member Author

ronag commented Jul 14, 2019

@mcollina I assume that means that you are not in favor of adding a ended getter?

@ronag ronag mentioned this issue Jul 14, 2019
Closed
4 tasks
@ronag
Copy link
Member Author

ronag commented Aug 24, 2019

This has been sorted with writableEnded and writableFinished. Deprecation is separate thing.

@ronag ronag closed this as completed Aug 24, 2019
BridgeAR pushed a commit that referenced this issue Dec 10, 2019
@ronag @BridgeAR
doc: deprecate http finished
c6ab3af 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this issue Dec 10, 2019
@ronag @targos
doc: deprecate http finished
93ca4f4 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this issue Jan 14, 2020
@ronag @targos
doc: deprecate http finished
ec514a6 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@ronag @BethGriggs
doc: deprecate http finished
79521d3 
PR-URL: #28679
Refs: #28651
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcollina @Trott @ronag