Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/whatwg/web/ in file names? #24823

Closed
joyeecheung opened this issue Dec 4, 2018 · 7 comments
Closed

s/whatwg/web/ in file names? #24823

joyeecheung opened this issue Dec 4, 2018 · 7 comments

Comments

@joyeecheung
Copy link
Member

I was working on porting performance-timeline WPT into core the other day and I realized that it didn't make sense to use the word whatwg in the file name (like what we do to other web-thingy) because performance-timeline is standardized in W3C but not in WHATWG. It sounds reasonable to me to change the whatwg in file names into web as we mostly just use that word to refer to web and it seems somewhat strange to put the name of a working group there in the first place.

I don't think we currently surface the word whatwg in APIs, it's only used to name files under benchmark and test so it should be fine to simply rename those files maintenance-wise.

cc @nodejs/open-standards @jasnell @nodejs/url any thoughts?
@targos
Copy link
Member

targos commented Dec 4, 2018

If the tests comme from from the wpt repository, I suggest to put wpt in the name instead of whatwg or web.

@joyeecheung
Copy link
Member Author

@targos The majority of whatwg in file names are of our own tests to Web APIs (in addition to WPT, some pending to be upstreamed, e.g. test-whatwg-url-custom-*), and of benchmarks (legacy-vs-whatwg-*). In the context of WPT drivers in test/wpt I think we can just rename those to something like test-url.js

@targos
Copy link
Member

targos commented Dec 4, 2018

I think we should keep whatwg for the URL module. That's how it's called in the docs too (The WHATWG URL API)

@joyeecheung
Copy link
Member Author

@targos You mean keeping them in the file names, or in the docs, or in general mentioning when we talk about things? I think it's right to keep mentioning WHATWG in docs (and also in comments since we are usually pasting links to whatwg.org anyway), but it seems strange to put those in file names, when we don't put the word w3c in perf_hooks tests..(that'll make the file names look even stranger..)

@targos
Copy link
Member

targos commented Dec 4, 2018

I wouldn't be confused if we kept whatwg in the name of files related to the WHATWG URL module and used web for others such as perf_hooks. I wouldn't object to renaming them. I just don't feel the need, personally.

@joyeecheung
Copy link
Member Author

@targos I see. For now, I think I will just remove the reference of whatwg in test/wpt, since that's where I was hitting the confusion - that also makes the file names more succinct, anyway.

@joyeecheung joyeecheung mentioned this issue Dec 4, 2018
Closed
3 tasks
Trott pushed a commit to Trott/io.js that referenced this issue Dec 15, 2018
@joyeecheung @Trott
test: remove reference to whatwg in file names under test/wpt
a96ba1c 
WPT covers standards in both W3C and WHATWG, as such it would be
strange to make this disparity explicit in our file names
(e.g. when testing standards that are solely in W3C, like
performance-timeline). Remove the reference to WHATWG will
also make the file names shorter.

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this issue Dec 15, 2018
@joyeecheung @Trott
test: improve WPT runner name matching
b520254 
This patch:

- Support wildcards(*) in WPT runner name matching (needed by e.g.
  encoding where all the tests requires i18n support in the build)
- Print failure reasons when encountering an expected failure
- Fix a bug in copyGlobalsFromObject (previously it copies
  properties from `global` instead of the given `obj`)

Previously an expected failure is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
```

Now it is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
missing Request and Response
```

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 18, 2018
@joyeecheung @BethGriggs
test: remove reference to whatwg in file names under test/wpt
da984be 
WPT covers standards in both W3C and WHATWG, as such it would be
strange to make this disparity explicit in our file names
(e.g. when testing standards that are solely in W3C, like
performance-timeline). Remove the reference to WHATWG will
also make the file names shorter.

PR-URL: #24826
Refs: #24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
BethGriggs pushed a commit that referenced this issue Dec 18, 2018
@joyeecheung @BethGriggs
test: improve WPT runner name matching
7e0dbc6 
This patch:

- Support wildcards(*) in WPT runner name matching (needed by e.g.
  encoding where all the tests requires i18n support in the build)
- Print failure reasons when encountering an expected failure
- Fix a bug in copyGlobalsFromObject (previously it copies
  properties from `global` instead of the given `obj`)

Previously an expected failure is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
```

Now it is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
missing Request and Response
```

PR-URL: #24826
Refs: #24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sagitsofan pushed a commit to sagitsofan/node that referenced this issue Dec 24, 2018
@joyeecheung @sagitsofan
test: remove reference to whatwg in file names under test/wpt
0fcd047 
WPT covers standards in both W3C and WHATWG, as such it would be
strange to make this disparity explicit in our file names
(e.g. when testing standards that are solely in W3C, like
performance-timeline). Remove the reference to WHATWG will
also make the file names shorter.

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
sagitsofan pushed a commit to sagitsofan/node that referenced this issue Dec 24, 2018
@joyeecheung @sagitsofan
test: improve WPT runner name matching
ceafd58 
This patch:

- Support wildcards(*) in WPT runner name matching (needed by e.g.
  encoding where all the tests requires i18n support in the build)
- Print failure reasons when encountering an expected failure
- Fix a bug in copyGlobalsFromObject (previously it copies
  properties from `global` instead of the given `obj`)

Previously an expected failure is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
```

Now it is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
missing Request and Response
```

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@joyeecheung @refack
test: remove reference to whatwg in file names under test/wpt
199d1c3 
WPT covers standards in both W3C and WHATWG, as such it would be
strange to make this disparity explicit in our file names
(e.g. when testing standards that are solely in W3C, like
performance-timeline). Remove the reference to WHATWG will
also make the file names shorter.

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@joyeecheung @refack
test: improve WPT runner name matching
4d57ff8 
This patch:

- Support wildcards(*) in WPT runner name matching (needed by e.g.
  encoding where all the tests requires i18n support in the build)
- Print failure reasons when encountering an expected failure
- Fix a bug in copyGlobalsFromObject (previously it copies
  properties from `global` instead of the given `obj`)

Previously an expected failure is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
```

Now it is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
missing Request and Response
```

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 26, 2020

Closing as there's been no activity in quite some time. Can reopen if this is still an issue

@jasnell jasnell closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jasnell @targos @joyeecheung